Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 57633007: Merge gpu_switching_list into gpu_driver_bug_list. (Closed)

Created:
7 years, 1 month ago by Zhenyao Mo
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org
Visibility:
Public.

Description

Patch Set 1 : cleanup #

Patch Set 2 : refactor #

Patch Set 3 : clean #

Patch Set 4 : always apply user-specified switching option #

Total comments: 4

Patch Set 5 : final #

Patch Set 6 : final final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -423 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 2 3 4 1 chunk +0 lines, -19 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.h View 4 chunks +0 lines, -7 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 2 3 4 11 chunks +23 lines, -69 lines 0 comments Download
M content/gpu/gpu_main.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 3 4 2 chunks +30 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_list_unittest.cc View 2 chunks +51 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +4 lines, -0 lines 0 comments Download
D gpu/config/gpu_switching_list.h View 1 chunk +0 lines, -29 lines 0 comments Download
D gpu/config/gpu_switching_list.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D gpu/config/gpu_switching_list_json.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D gpu/config/gpu_switching_list_unittest.cc View 1 chunk +0 lines, -108 lines 0 comments Download
D gpu/config/gpu_switching_option.h View 1 chunk +0 lines, -22 lines 0 comments Download
M gpu/config/gpu_util.h View 1 2 chunks +4 lines, -9 lines 0 comments Download
M gpu/config/gpu_util.cc View 1 3 chunks +17 lines, -23 lines 0 comments Download
M gpu/config/gpu_util_unittest.cc View 1 2 chunks +21 lines, -28 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/gpu_config.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/gl_switches.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Zhenyao Mo
kbr, bajones: please review. This is tested on a mac with dual gpus.
7 years, 1 month ago (2013-11-05 02:05:17 UTC) #1
Zhenyao Mo
I noticed the dual gpu mechanism, including gpu_switching_manager, can be further simplified, but I'll do ...
7 years, 1 month ago (2013-11-05 02:06:11 UTC) #2
Ken Russell (switch to Gerrit)
This is excellent. LGTM. https://codereview.chromium.org/57633007/diff/190001/gpu/config/gpu_util_unittest.cc File gpu/config/gpu_util_unittest.cc (right): https://codereview.chromium.org/57633007/diff/190001/gpu/config/gpu_util_unittest.cc#newcode52 gpu/config/gpu_util_unittest.cc:52: // zero feature. Zero features. ...
7 years, 1 month ago (2013-11-05 02:31:55 UTC) #3
Zhenyao Mo
Daniel: gpu/ owner approval
7 years, 1 month ago (2013-11-05 02:45:15 UTC) #4
bajones
This is a great cleanup! LGTM!
7 years, 1 month ago (2013-11-05 04:06:53 UTC) #5
Zhenyao Mo
also add piman. piman or sievers, whoever comes across this CL first, can you stamp ...
7 years, 1 month ago (2013-11-05 19:24:07 UTC) #6
no sievers
lgtm https://codereview.chromium.org/57633007/diff/190001/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/57633007/diff/190001/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode312 content/browser/gpu/gpu_data_manager_impl_private.cc:312: if (option == switches::kGpuSwitchingOptionNameForceIntegrated) { nit: else if
7 years, 1 month ago (2013-11-05 19:41:23 UTC) #7
piman
LGTM. Nice cleanup.
7 years, 1 month ago (2013-11-05 19:43:37 UTC) #8
Zhenyao Mo
https://codereview.chromium.org/57633007/diff/190001/content/browser/gpu/gpu_data_manager_impl_private.cc File content/browser/gpu/gpu_data_manager_impl_private.cc (right): https://codereview.chromium.org/57633007/diff/190001/content/browser/gpu/gpu_data_manager_impl_private.cc#newcode312 content/browser/gpu/gpu_data_manager_impl_private.cc:312: if (option == switches::kGpuSwitchingOptionNameForceIntegrated) { On 2013/11/05 19:41:23, sievers ...
7 years, 1 month ago (2013-11-05 19:45:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/57633007/420001
7 years, 1 month ago (2013-11-05 20:05:28 UTC) #10
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-05 20:57:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/57633007/690001
7 years, 1 month ago (2013-11-05 22:17:24 UTC) #12
Zhenyao Mo
7 years, 1 month ago (2013-11-05 23:53:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #6 manually as r233143 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698