Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 57633003: Make PushIfNeeded do what is says. (Closed)

Created:
7 years, 1 month ago by aberent
Modified:
7 years, 1 month ago
Reviewers:
craigdh
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make PushIfNeeded do what is says. PushIfNeeded was pushing unconditionally when either the source or destination directory included a symbolic link it its path. This CL fixes that. NOTRY=True BUG=314578 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233387

Patch Set 1 #

Patch Set 2 : Remove unnecessary change to call of HostHas #

Total comments: 2

Patch Set 3 : Add requested comment and fix gpylint issue. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M build/android/pylib/android_commands.py View 1 2 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
aberent
7 years, 1 month ago (2013-11-04 13:54:05 UTC) #1
craigdh
lgtm, thanks!
7 years, 1 month ago (2013-11-05 19:08:33 UTC) #2
craigdh
https://codereview.chromium.org/57633003/diff/30001/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/57633003/diff/30001/build/android/pylib/android_commands.py#newcode845 build/android/pylib/android_commands.py:845: real_host_path = os.path.realpath(host_path) add a comment here explaining why ...
7 years, 1 month ago (2013-11-05 19:10:07 UTC) #3
aberent
https://codereview.chromium.org/57633003/diff/30001/build/android/pylib/android_commands.py File build/android/pylib/android_commands.py (right): https://codereview.chromium.org/57633003/diff/30001/build/android/pylib/android_commands.py#newcode845 build/android/pylib/android_commands.py:845: real_host_path = os.path.realpath(host_path) On 2013/11/05 19:10:08, craigdh wrote: > ...
7 years, 1 month ago (2013-11-05 19:58:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/57633003/140001
7 years, 1 month ago (2013-11-05 20:05:20 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34572
7 years, 1 month ago (2013-11-05 20:43:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/57633003/140001
7 years, 1 month ago (2013-11-05 20:59:22 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34585
7 years, 1 month ago (2013-11-05 21:46:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/57633003/310001
7 years, 1 month ago (2013-11-06 14:14:14 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94963
7 years, 1 month ago (2013-11-06 18:08:43 UTC) #10
craigdh
You've passed the android trybots which are the only bots this change can affect, feel ...
7 years, 1 month ago (2013-11-06 18:17:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/57633003/310001
7 years, 1 month ago (2013-11-06 20:33:46 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 21:59:58 UTC) #13
Message was sent while issue was closed. 
Change committed as 233387

Powered by Google App Engine
This is Rietveld 408576698