Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: Source/bindings/core/v8/V8StringResource.h

Issue 576323004: Drop unnecessary v8::TryCatch in V8StringResource::prepare() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: attempt at fixing before-unload-return-bad-value.html Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/storage/websql/sql-error-codes-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8StringResource.h
diff --git a/Source/bindings/core/v8/V8StringResource.h b/Source/bindings/core/v8/V8StringResource.h
index a061f6146072bdf338e5262cdf035425bdc7c7dd..a84c216c4561bd6383a2756b7de65d06e1ffcd63 100644
--- a/Source/bindings/core/v8/V8StringResource.h
+++ b/Source/bindings/core/v8/V8StringResource.h
@@ -215,13 +215,10 @@ public:
}
m_mode = DoNotExternalize;
- v8::TryCatch block;
m_v8Object = m_v8Object->ToString();
// Handle the case where an exception is thrown as part of invoking toString on the object.
- if (block.HasCaught()) {
- block.ReThrow();
+ if (m_v8Object.IsEmpty())
return false;
- }
return true;
}
operator String() const { return toString<String>(); }
« no previous file with comments | « LayoutTests/storage/websql/sql-error-codes-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698