Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 576323003: Fix use after free in HWNDMessageHandler (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
ananta
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix use after free in HWNDMessageHandler BUG=412106 TEST=none R=ananta@chromium.org Committed: https://crrev.com/bb44e94c0e1c5d26bfe053bdb5536893c8d35ed3 Cr-Commit-Position: refs/heads/master@{#295463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
sky
6 years, 3 months ago (2014-09-17 23:36:31 UTC) #1
ananta
This change LGTM. The code here is repeated in a bunch of other handlers in ...
6 years, 3 months ago (2014-09-18 00:55:49 UTC) #2
sky
Good idea. I'll look into that separately.
6 years, 3 months ago (2014-09-18 12:51:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/576323003/1
6 years, 3 months ago (2014-09-18 12:51:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6b49e37bcadc141f37dc50860a7d204e0401afd5
6 years, 3 months ago (2014-09-18 13:50:08 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 13:50:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb44e94c0e1c5d26bfe053bdb5536893c8d35ed3
Cr-Commit-Position: refs/heads/master@{#295463}

Powered by Google App Engine
This is Rietveld 408576698