Issue 576293003: gn: Escape include path strings for shell

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 576293003: gn: Escape include path strings for shell (Closed)

Created:
6 years, 3 months ago by ckocagil

Modified:
6 years, 3 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina, scottmg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

gn: Escape include path strings for shell BUG=414880 R=brettw Committed: https://crrev.com/6e697271dfc0cf5e45ed759485bda91b7d7737ca Cr-Commit-Position: refs/heads/master@{#295620}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	tools/gn/ninja_binary_target_writer.cc	View		3 chunks	+11 lines, -3 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/576293003/1

6 years, 3 months ago (2014-09-18 22:49:17 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 7624cc126a4f21156a7933f2592ea8bfb15e97ce

6 years, 3 months ago (2014-09-19 00:17:59 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-19 00:18:21 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6e697271dfc0cf5e45ed759485bda91b7d7737ca
Cr-Commit-Position: refs/heads/master@{#295620}