Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 576113002: Reland "Use chromeos accelerometer reader and support only lid accelerometer. (patchset #3 id:60001… (Closed)

Created:
6 years, 3 months ago by flackr
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat, oshima
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reland "Use chromeos accelerometer reader and support only lid accelerometer. (patchset #3 id:60001 of https://codereview.chromium.org/574113002/)" Relands commit and fixes compiler error. TBR=oshima,derat BUG=380831 TEST=Glimmer/clapper still work, manually tested not having a base accelerometer. Committed: https://crrev.com/b34f096d711a37bcd620113fc9d370a5ca88804b Cr-Commit-Position: refs/heads/master@{#295285}

Patch Set 1 #

Patch Set 2 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -575 lines) Patch
M ash/accelerometer/accelerometer_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M athena/athena.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M athena/main/athena_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/main/athena_main.cc View 1 chunk +3 lines, -2 lines 0 comments Download
D athena/system/device_socket_listener.h View 1 chunk +0 lines, -48 lines 0 comments Download
D athena/system/device_socket_listener.cc View 1 chunk +0 lines, -310 lines 0 comments Download
M athena/system/orientation_controller.h View 2 chunks +9 lines, -38 lines 0 comments Download
M athena/system/orientation_controller.cc View 2 chunks +12 lines, -103 lines 0 comments Download
M athena/system/system_ui_impl.cc View 5 chunks +6 lines, -8 lines 0 comments Download
M athena/test/athena_test_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/athena/chrome_browser_main_extra_parts_athena.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chromeos/accelerometer/accelerometer_reader.h View 1 3 chunks +13 lines, -7 lines 0 comments Download
M chromeos/accelerometer/accelerometer_reader.cc View 1 7 chunks +84 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
flackr
TBR'ing for trivial changes in patchset 2. Patchset 1 originally reviewed in https://codereview.chromium.org/574113002/
6 years, 3 months ago (2014-09-17 15:21:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576113002/20001
6 years, 3 months ago (2014-09-17 15:22:54 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 8d35372ba806dddccae69d51afe914ec06e7da1b
6 years, 3 months ago (2014-09-17 16:19:45 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 16:20:30 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b34f096d711a37bcd620113fc9d370a5ca88804b
Cr-Commit-Position: refs/heads/master@{#295285}

Powered by Google App Engine
This is Rietveld 408576698