Add support for 'orientation' in Manifest.

content/renderer/manifest/manifest_parser_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/manifest/manifest_parser.h"
 
 #include "base/strings/string_util.h"
 #include "content/public/common/manifest.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 24 matching lines @@
 
 TEST_F(ManifestParserTest, EmptyStringNull) {
   Manifest manifest = ParseManifest("");
 
   // A parsing error is equivalent to an empty manifest.
   ASSERT_TRUE(manifest.IsEmpty());
   ASSERT_TRUE(manifest.name.is_null());
   ASSERT_TRUE(manifest.short_name.is_null());
   ASSERT_TRUE(manifest.start_url.is_empty());
   ASSERT_EQ(manifest.display, Manifest::DISPLAY_MODE_UNSPECIFIED);
+  ASSERT_EQ(manifest.orientation, blink::WebScreenOrientationLockDefault);
 }
 
 TEST_F(ManifestParserTest, ValidNoContentParses) {
   Manifest manifest = ParseManifest("{}");
 
   // Check that all the fields are null in that case.
   ASSERT_TRUE(manifest.IsEmpty());
   ASSERT_TRUE(manifest.name.is_null());
   ASSERT_TRUE(manifest.short_name.is_null());
   ASSERT_TRUE(manifest.start_url.is_empty());
   ASSERT_EQ(manifest.display, Manifest::DISPLAY_MODE_UNSPECIFIED);
+  ASSERT_EQ(manifest.orientation, blink::WebScreenOrientationLockDefault);
 }
 
 TEST_F(ManifestParserTest, NameParseRules) {
   // Smoke test.
   {
     Manifest manifest = ParseManifest("{ \"name\": \"foo\" }");
     ASSERT_TRUE(EqualsASCII(manifest.name.string(), "foo"));
     ASSERT_FALSE(manifest.IsEmpty());
   }
 
@@ skipping 155 matching lines @@
     EXPECT_EQ(manifest.display, Manifest::DISPLAY_MODE_BROWSER);
   }
 
   // Case insensitive.
   {
     Manifest manifest = ParseManifest("{ \"display\": \"BROWSER\" }");
     EXPECT_EQ(manifest.display, Manifest::DISPLAY_MODE_BROWSER);
   }
 }
 
+TEST_F(ManifestParserTest, OrientationParserRules) {
+  // Smoke test.
+  {
+    Manifest manifest = ParseManifest("{ \"orientation\": \"natural\" }");
+    EXPECT_EQ(manifest.orientation, blink::WebScreenOrientationLockNatural);
+    EXPECT_FALSE(manifest.IsEmpty());
+  }
+
+  // Trim whitespaces.
+  {
+    Manifest manifest = ParseManifest("{ \"orientation\": \"natural\" }");
+    EXPECT_EQ(manifest.orientation, blink::WebScreenOrientationLockNatural);
+  }
+
+  // Don't parse if name isn't a string.
+  {
+    Manifest manifest = ParseManifest("{ \"orientation\": {} }");
+    EXPECT_EQ(manifest.orientation, blink::WebScreenOrientationLockDefault);
+  }
+
+  // Don't parse if name isn't a string.
+  {
+    Manifest manifest = ParseManifest("{ \"orientation\": 42 }");
+    EXPECT_EQ(manifest.orientation, blink::WebScreenOrientationLockDefault);
+  }
+
+  // Parse fails if string isn't known.
+  {
+    Manifest manifest = ParseManifest("{ \"orientation\": \"naturalish\" }");
+    EXPECT_EQ(manifest.orientation, blink::WebScreenOrientationLockDefault);
+  }
+
+  // Accept 'any'.
+  {
+    Manifest manifest = ParseManifest("{ \"orientation\": \"any\" }");
+    EXPECT_EQ(manifest.orientation, blink::WebScreenOrientationLockAny);
+  }
+
+  // Accept 'natural'.
+  {
+    Manifest manifest = ParseManifest("{ \"orientation\": \"natural\" }");
+    EXPECT_EQ(manifest.orientation, blink::WebScreenOrientationLockNatural);
+  }
+
+  // Accept 'landscape'.
+  {
+    Manifest manifest = ParseManifest("{ \"orientation\": \"landscape\" }");
+    EXPECT_EQ(manifest.orientation, blink::WebScreenOrientationLockLandscape);
+  }
+
+  // Accept 'landscape-primary'.
+  {
+    Manifest manifest =
+        ParseManifest("{ \"orientation\": \"landscape-primary\" }");
+    EXPECT_EQ(manifest.orientation,
+              blink::WebScreenOrientationLockLandscapePrimary);
+  }
+
+  // Accept 'landscape-secondary'.
+  {
+    Manifest manifest =
+        ParseManifest("{ \"orientation\": \"landscape-secondary\" }");
+    EXPECT_EQ(manifest.orientation,
+              blink::WebScreenOrientationLockLandscapeSecondary);
+  }
+
+  // Accept 'portrait'.
+  {
+    Manifest manifest = ParseManifest("{ \"orientation\": \"portrait\" }");
+    EXPECT_EQ(manifest.orientation, blink::WebScreenOrientationLockPortrait);
+  }
+
+  // Accept 'portrait-primary'.
+  {
+    Manifest manifest =
+      ParseManifest("{ \"orientation\": \"portrait-primary\" }");
+    EXPECT_EQ(manifest.orientation,
+              blink::WebScreenOrientationLockPortraitPrimary);
+  }
+
+  // Accept 'portrait-secondary'.
+  {
+    Manifest manifest =
+        ParseManifest("{ \"orientation\": \"portrait-secondary\" }");
+    EXPECT_EQ(manifest.orientation,
+              blink::WebScreenOrientationLockPortraitSecondary);
+  }
+
+  // Case insensitive.
+  {
+    Manifest manifest = ParseManifest("{ \"orientation\": \"LANDSCAPE\" }");
+    EXPECT_EQ(manifest.orientation, blink::WebScreenOrientationLockLandscape);
+  }
+}
+
 } // namespace content