Source/core/editing/DOMSelection.cpp - Issue 576073003: Removal of more temporary Range objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/DOMSelection.cpp

Issue 576073003: Removal of more temporary Range objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix build; accidentally removed .get() call Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/DOMSelection.cpp

diff --git a/Source/core/editing/DOMSelection.cpp b/Source/core/editing/DOMSelection.cpp

index d4eaa607884304371ecd154f480bf656ea4e36e6..b05ba0ffcd36d2cf05b771bf00a9503465c06d1b 100644

--- a/Source/core/editing/DOMSelection.cpp

+++ b/Source/core/editing/DOMSelection.cpp

@@ -505,7 +505,10 @@ String DOMSelection::toString()

if (!m_frame)

return String();

- return plainText(m_frame->selection().selection().toNormalizedRange().get());

+ Position start, end;

+ if (m_frame->selection().selection().toNormalizedPositions(start, end))

+ return plainText(start, end);

+ return emptyString();

}

Node* DOMSelection::shadowAdjustedNode(const Position& position) const

« no previous file with comments | « Source/core/editing/CompositeEditCommand.cpp ('k') | Source/core/editing/SpellChecker.cpp » ('j') | no next file with comments »