Removal of more temporary Range objects.

Source/core/dom/DocumentMarkerController.cpp

Index: Source/core/dom/DocumentMarkerController.cpp
diff --git a/Source/core/dom/DocumentMarkerController.cpp b/Source/core/dom/DocumentMarkerController.cpp
index 354d82a857fc1499f6d60a36896db5202f0f5dd0..bf9103837e5643a5081338314b93696310487250 100644
--- a/Source/core/dom/DocumentMarkerController.cpp
+++ b/Source/core/dom/DocumentMarkerController.cpp
@@ -119,6 +119,22 @@ void DocumentMarkerController::addMarker(Range* range, DocumentMarker::MarkerTyp
 
 }
 
+void DocumentMarkerController::addMarker(const Position& start, const Position& end, DocumentMarker::MarkerType type, const String& description)
+{
+    // Use a TextIterator to visit the potentially multiple nodes the range covers.
+    for (TextIterator markedText(start, end); !markedText.atEnd(); markedText.advance()) {
+        addMarker(markedText.startContainer(), DocumentMarker(type, markedText.startOffset(), markedText.endOffset(), description));
+    }
+}
+
+void DocumentMarkerController::addMarker(const Position& start, const Position& end, DocumentMarker::MarkerType type)
+{
+    // Use a TextIterator to visit the potentially multiple nodes the range covers.
+    for (TextIterator markedText(start, end); !markedText.atEnd(); markedText.advance()) {
+        addMarker(markedText.startContainer(), DocumentMarker(type, markedText.startOffset(), markedText.endOffset()));

[yosin_UTC9, 2014/09/18 01:08:51]

nit: It seems ctor of |DocumentMarker| check |description.isEmpty()|, so we can
make this function to call |addMarker(const Position&, const Position&,
DocumentMarker::MakrerType, const String&)| with |emptyString()|.

It is OK to do this in another patch, because other overload functions don't do
so.

[Mads Ager (chromium), 2014/09/18 06:58:49]

Thanks, that is true. Looks like this can be simplified a bit using default
arguments. Let me create a separate patch for that.

+    }
+}
+
 void DocumentMarkerController::addTextMatchMarker(const Range* range, bool activeMatch)
 {
     // Use a TextIterator to visit the potentially multiple nodes the range covers.