Modify the behavior of cancel button in syncing status to cancel all jobs.

chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_manager/private_api_drive.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chromeos/drive/drive_integration_service.h"
 #include "chrome/browser/chromeos/extensions/file_manager/private_api_util.h"
@@ skipping 539 matching lines @@
 
   if (error == drive::FILE_ERROR_OK) {
     SendResponse(true);
   } else {
     SetError(drive::FileErrorToString(error));
     SendResponse(false);
   }
 }
 
 bool FileManagerPrivateCancelFileTransfersFunction::RunAsync() {
-  using extensions::api::file_manager_private::CancelFileTransfers::Params;
-  const scoped_ptr<Params> params(Params::Create(*args_));
-  EXTENSION_FUNCTION_VALIDATE(params);

[kinaba, 2014/09/18 02:15:54]

I guess you are planning to update the IDL of this API as well in the later
patch.
Could you add a comment on the plan to the patch description?

[iseki, 2014/09/18 05:32:28]

Done.

-
   drive::DriveIntegrationService* integration_service =
       drive::DriveIntegrationServiceFactory::FindForProfile(GetProfile());
   if (!integration_service || !integration_service->IsMounted())
     return false;
 
   // Create the mapping from file path to job ID.

[kinaba, 2014/09/18 02:15:54]

Please update the comment.

[iseki, 2014/09/18 05:32:28]

Done.

   drive::JobListInterface* job_list = integration_service->job_list();
   DCHECK(job_list);
   std::vector<drive::JobInfo> jobs = job_list->GetJobInfoList();
 
-  typedef std::map<base::FilePath, std::vector<drive::JobID> > PathToIdMap;
-  PathToIdMap path_to_id_map;
-  for (size_t i = 0; i < jobs.size(); ++i) {
-    if (drive::IsActiveFileTransferJobInfo(jobs[i]))
-      path_to_id_map[jobs[i].file_path].push_back(jobs[i].job_id);
-  }
-
   // Cancel by Job ID.

[kinaba, 2014/09/18 02:15:54]

Please update the comment.

[iseki, 2014/09/18 05:32:28]

Done.

   std::vector<linked_ptr<api::file_manager_private::
                          FileTransferCancelStatus> > responses;
-  for (size_t i = 0; i < params->file_urls.size(); ++i) {
-    base::FilePath file_path = file_manager::util::GetLocalPathFromURL(
-        render_view_host(), GetProfile(), GURL(params->file_urls[i]));
-    if (file_path.empty())
-      continue;
-
-    DCHECK(drive::util::IsUnderDriveMountPoint(file_path));
-    file_path = drive::util::ExtractDrivePath(file_path);
-
-    // Cancel all the jobs for the file.
-    PathToIdMap::iterator it = path_to_id_map.find(file_path);
-    if (it != path_to_id_map.end()) {
-      for (size_t i = 0; i < it->second.size(); ++i)
-        job_list->CancelJob(it->second[i]);
+  for (size_t i = 0; i < jobs.size(); ++i) {
+    if (drive::IsActiveFileTransferJobInfo(jobs[i])) {
+      job_list->CancelJob(jobs[i].job_id);
+      linked_ptr<api::file_manager_private::FileTransferCancelStatus> result(
+          new api::file_manager_private::FileTransferCancelStatus);
+      result->canceled = true;
+      result->file_url = jobs[i].file_path.value();

[kinaba, 2014/09/18 02:15:54]

These response values are not used at all in Files.app actually.
Could you remove them entirely on this occasion?

Or, if you have a plan to use these value, please be sure to return file_url,
not file_path.

[iseki, 2014/09/18 05:32:28]

Done.

+      responses.push_back(result);
     }
-    linked_ptr<api::file_manager_private::FileTransferCancelStatus> result(
-        new api::file_manager_private::FileTransferCancelStatus);
-    result->canceled = it != path_to_id_map.end();
-    // TODO(kinaba): simplify cancelFileTransfer() to take single URL each time,
-    // and eliminate this field; it is just returning a copy of the argument.
-    result->file_url = params->file_urls[i];
-    responses.push_back(result);
   }
   results_ = api::file_manager_private::CancelFileTransfers::Results::Create(
       responses);
   SendResponse(true);
   return true;
 }
 
 bool FileManagerPrivateSearchDriveFunction::RunAsync() {
   using extensions::api::file_manager_private::SearchDrive::Params;
   const scoped_ptr<Params> params(Params::Create(*args_));
@@ skipping 416 matching lines @@
     return;
   }
 
   const std::string url = download_url_ + "?access_token=" + access_token;
   SetResult(new base::StringValue(url));
 
   SendResponse(true);
 }
 
 }  // namespace extensions