Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 576023003: Clarify build test for presense of 'float copysign(float, float)'. (Closed)

Created:
6 years, 3 months ago by bungeman-skia
Modified:
6 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Clarify build test for presense of 'float copysign(float, float)'. Clang-cl reports __cplusplus based on the version of clang instead of reporting the __cplusplus the vc++ version _MSC_VER would. This is important as the _MSC_VER also indicates which vc++ runtime library will be used. As a result, do not trust the __cplusplus version reported by clang-cl. This change clarifies the intent of https://skia.googlesource.com/skia/+/c34b0d4e9ad5806c1f882a1f85191f2ea8ddcdba Committed: https://skia.googlesource.com/skia/+/ef59adba5b5058c60c1b92b17904b2813be644ea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M include/core/SkFloatingPoint.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
bungeman-skia
The idea here is to comment and clarify the intent and reason for https://codereview.chromium.org/526813002/ .
6 years, 3 months ago (2014-09-17 16:26:29 UTC) #2
reed1
lgtm
6 years, 3 months ago (2014-09-17 17:51:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576023003/1
6 years, 3 months ago (2014-09-17 17:56:56 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 18:16:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as ef59adba5b5058c60c1b92b17904b2813be644ea

Powered by Google App Engine
This is Rietveld 408576698