Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 576003002: Full JSON file has to be read instead of first line. (Closed)

Created:
6 years, 3 months ago by patro
Modified:
6 years, 3 months ago
Reviewers:
Dirk Pranke, vivekg
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Full JSON file has to be read instead of first line. In GenerateDashBoard class only the first line of json files is read. It will fail if we have multi-line JSON files. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
patro
Kindly Review Thanks and Regards, Shyam Patro
6 years, 3 months ago (2014-09-17 07:57:11 UTC) #2
Dirk Pranke
lgtm
6 years, 3 months ago (2014-09-17 15:21:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/576003002/1
6 years, 3 months ago (2014-09-17 16:56:00 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 17:00:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182168

Powered by Google App Engine
This is Rietveld 408576698