Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 575923004: Fix is_chrome_branded check in chrome_repack_locales.gni. (Closed)

Created:
6 years, 3 months ago by engedy
Modified:
6 years, 3 months ago
CC:
brettw, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix is_chrome_branded check in chrome_repack_locales.gni. It was using chromium resources when it should have used chrome resources, and vice versa. BUG=None Committed: https://crrev.com/8afbc8c653a3feae3831cd562d0abf9fed3a7964 Cr-Commit-Position: refs/heads/master@{#295681}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/chrome_repack_locales.gni View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
engedy
I think we had a typo here, PTAL.
6 years, 3 months ago (2014-09-17 17:16:16 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-09-17 19:28:39 UTC) #4
engedy
@Jochen, could you PTAL for OWNER's approval.
6 years, 3 months ago (2014-09-18 08:00:54 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-18 18:28:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575923004/1
6 years, 3 months ago (2014-09-18 23:11:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/68717) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/57983) win_gpu ...
6 years, 3 months ago (2014-09-18 23:19:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575923004/20001
6 years, 3 months ago (2014-09-19 07:42:45 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b7d0a1f13ea65c0888f3d8f11400fda580ada875
6 years, 3 months ago (2014-09-19 08:38:35 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 08:39:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8afbc8c653a3feae3831cd562d0abf9fed3a7964
Cr-Commit-Position: refs/heads/master@{#295681}

Powered by Google App Engine
This is Rietveld 408576698