Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 575893004: Revert of mojo: Add a runloop utility in python (Closed)

Created:
6 years, 3 months ago by battre
Modified:
6 years, 3 months ago
Reviewers:
Chris Masone, sdefresne, qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of mojo: Add a runloop utility in python (patchset #3 id:40001 of https://codereview.chromium.org/552783004/) Reason for revert: This fails on the build bots. ====================================================================== ERROR: testRunLoop (runloop_unittest.RunLoopTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/mnt/data/b/build/slave/Linux_Tests/build/src/mojo/python/tests/runloop_unittest.py", line 24, in testRunLoop loop = system.RunLoop() AttributeError: 'module' object has no attribute 'RunLoop' http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/13669/steps/mojo_python_bindings_tests/logs/stdio Original issue's description: > mojo: Add a runloop utility in python > > This is necessary to be able to use async operation on handles. > > R=sdefresne@chromium.org,cmasone@chromium.org > > Committed: https://crrev.com/830c88cca3c89dfabcbfc360ac7c035a020b8307 > Cr-Commit-Position: refs/heads/master@{#295267} TBR=cmasone@chromium.org,sdefresne@chromium.org,qsr@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/0a1b918e47c7f2723a6542b62d69e7f271f731a3 Cr-Commit-Position: refs/heads/master@{#295280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -222 lines) Patch
M mojo/mojo.gyp View 1 chunk +2 lines, -7 lines 0 comments Download
M mojo/public/python/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
D mojo/public/python/mojo/c_environment.pxd View 1 chunk +0 lines, -31 lines 0 comments Download
M mojo/public/python/mojo/system.pyx View 2 chunks +0 lines, -31 lines 0 comments Download
D mojo/public/python/src/python_system_helper.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/public/python/src/python_system_helper.cc View 1 chunk +0 lines, -79 lines 0 comments Download
D mojo/python/tests/runloop_unittest.py View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/cython/rules.gni View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
battre
Created Revert of mojo: Add a runloop utility in python
6 years, 3 months ago (2014-09-17 15:42:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575893004/1
6 years, 3 months ago (2014-09-17 15:43:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0b92109faf863ac1c74529f1213ab1bd9c3ee32d
6 years, 3 months ago (2014-09-17 15:44:16 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0a1b918e47c7f2723a6542b62d69e7f271f731a3 Cr-Commit-Position: refs/heads/master@{#295280}
6 years, 3 months ago (2014-09-17 15:45:05 UTC) #4
sdefresne
6 years, 3 months ago (2014-09-17 16:00:30 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698