Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 575883002: Fix handling of failed distillation. (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 3 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix handling of failed distillation. Currently, when distillation fails, the TaskTracker signals that a source has finished. It then checks if all sources are done (and if not, it will wait to call the callback). The check for sources done though assumes that if distiller_ is non-null, then distillation is still in progress. So, we should be deleting/releasing distiller_ when it finished (and before signalling that the source is finished). This also updates the standalone content extractor to fail if extraction of some url fails. Committed: https://crrev.com/39186c37d96231e4b48fcc63bf65d4100b0b6735 Cr-Commit-Position: refs/heads/master@{#295599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M components/dom_distiller/core/task_tracker.cc View 2 chunks +8 lines, -1 line 0 comments Download
M components/dom_distiller/core/task_tracker_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M components/dom_distiller/standalone/content_extractor.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cjhopman
nyquist: *
6 years, 3 months ago (2014-09-16 20:30:21 UTC) #2
nyquist
lgtm
6 years, 3 months ago (2014-09-18 21:49:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575883002/1
6 years, 3 months ago (2014-09-18 22:00:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as bcb95a9710651a5feb3123fca6746f6793946944
6 years, 3 months ago (2014-09-18 23:33:32 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 23:34:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39186c37d96231e4b48fcc63bf65d4100b0b6735
Cr-Commit-Position: refs/heads/master@{#295599}

Powered by Google App Engine
This is Rietveld 408576698