Issue 57583008: Delete gpu/command_buffer/common/compiler_specific.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 57583008: Delete gpu/command_buffer/common/compiler_specific.h (Closed)

Created:
7 years, 1 month ago by Nico

Modified:
7 years, 1 month ago

Reviewers:
piman

CC:
chromium-reviews, piman+watch_chromium.org, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Delete gpu/command_buffer/common/compiler_specific.h command_buffer was historically included in nacl-compiled things, and base wasn't. These days, base is included in nacl-compiled things too, so the duplication can be removed. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232944

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -30 lines)			Patch
M	gpu/command_buffer/client/client_test_helper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation.h	View	2 chunks	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_implementation_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_interface_stub.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/gles2_trace_implementation.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/transfer_buffer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gpu/command_buffer/client/transfer_buffer_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	gpu/command_buffer/common/compiler_specific.h	View	1 chunk	+0 lines, -22 lines	0 comments	Download
M	gpu/command_buffer_common.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/57583008/1

7 years, 1 month ago (2013-11-05 06:24:08 UTC) #3

Message was sent while issue was closed.

Change committed as 232944

Expand Messages | Collapse Messages