Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: util/mach/mach_extensions.cc

Issue 575823002: Drop 10.5 support (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mach/mach_extensions.h ('k') | util/test/mac/mach_multiprocess.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mach/mach_extensions.cc
diff --git a/util/mach/mach_extensions.cc b/util/mach/mach_extensions.cc
index 5c5668c03207f23c76f17c93af9ff680584c5c99..d012538e694cd2f999eb89b3e31e642bb101650b 100644
--- a/util/mach/mach_extensions.cc
+++ b/util/mach/mach_extensions.cc
@@ -41,14 +41,6 @@ exception_mask_t ExcMaskAll() {
// See 10.6.8 xnu-1504.15.3/osfmk/mach/exception_types.h. 10.7 uses the same
// definition as 10.6. See 10.7.5 xnu-1699.32.7/osfmk/mach/exception_types.h
- //
- // The 10.5 SDK actually defined EXC_MASK_ALL as including EXC_MASK_CRASH.
- // Later SDKs removed EXC_MASK_CRASH from EXC_MASK_ALL, but placed it into a
- // new constant, EXC_MASK_VALID. For consistent behavior, don’t include
- // EXC_MASK_CRASH in the 10.5 EXC_MASK_ALL. Consumers that want EXC_MASK_ALL
- // along with EXC_MASK_CRASH must use ExcMaskAll() | EXC_MASK_CRASH
- // explicitly. 10.5 otherwise behaves identically to 10.6. See 10.5.8
- // xnu-1228.15.4/osfmk/mach/exception_types.h.
const exception_mask_t kExcMaskAll_10_6 =
EXC_MASK_BAD_ACCESS | EXC_MASK_BAD_INSTRUCTION | EXC_MASK_ARITHMETIC |
EXC_MASK_EMULATION | EXC_MASK_SOFTWARE | EXC_MASK_BREAKPOINT |
« no previous file with comments | « util/mach/mach_extensions.h ('k') | util/test/mac/mach_multiprocess.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698