Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: util/mac/process_reader.cc

Issue 575823002: Drop 10.5 support (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « compat/mac/servers/bootstrap.h ('k') | util/mac/process_types_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mac/process_reader.cc
diff --git a/util/mac/process_reader.cc b/util/mac/process_reader.cc
index e526315997b720f54cbe8072308606df1e3391ec..de48eba6bd622edfb68d2fcda63680b2b7565a2d 100644
--- a/util/mac/process_reader.cc
+++ b/util/mac/process_reader.cc
@@ -240,8 +240,7 @@ void ProcessReader::InitializeThreads() {
mach_msg_type_number_t thread_state_count =
Is64Bit() ? x86_THREAD_STATE64_COUNT : x86_THREAD_STATE32_COUNT;
- // TODO(mark): Use the AVX variants instead of the FLOAT variants? They’re
- // supported on 10.6 and later.
+ // TODO(mark): Use the AVX variants instead of the FLOAT variants?
const thread_state_flavor_t kFloatStateFlavor =
Is64Bit() ? x86_FLOAT_STATE64 : x86_FLOAT_STATE32;
mach_msg_type_number_t float_state_count =
@@ -354,8 +353,6 @@ void ProcessReader::InitializeModules() {
initialized_modules_ = true;
- // This API only works on Mac OS X 10.6 and higher. On Mac OS X 10.5, find the
- // “_dyld_all_image_infos” symbol in the loaded LC_LOAD_DYLINKER (dyld).
task_dyld_info_data_t dyld_info;
mach_msg_type_number_t count = TASK_DYLD_INFO_COUNT;
kern_return_t kr = task_info(
« no previous file with comments | « compat/mac/servers/bootstrap.h ('k') | util/mac/process_types_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698