Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 575783002: Update ForbiddenClosingTagElements list with elements with no end tag. (Closed)

Created:
6 years, 3 months ago by pals
Modified:
6 years, 3 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Update ForbiddenClosingTagElements list with elements with no end tag. As per the specification https://html.spec.whatwg.org/multipage/syntax.html#void-elements <menuitem>, <track>, <wbr> should not have end tag. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182285

Patch Set 1 #

Patch Set 2 : Removed chnages in cm/* #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
pals
PTAL.
6 years, 3 months ago (2014-09-16 12:55:21 UTC) #2
vsevik
lgtm Thanks!
6 years, 3 months ago (2014-09-17 07:35:01 UTC) #5
vsevik
Oh, sorry, but not lgtm. the cm/* files should be updated upstream in codemirror source ...
6 years, 3 months ago (2014-09-17 07:36:27 UTC) #7
pals
On 2014/09/17 07:36:27, vsevik wrote: > Oh, sorry, but not lgtm. > > the cm/* ...
6 years, 3 months ago (2014-09-17 09:48:06 UTC) #8
pals
On 2014/09/17 09:48:06, sanjoy_pal wrote: > On 2014/09/17 07:36:27, vsevik wrote: > > Oh, sorry, ...
6 years, 3 months ago (2014-09-18 11:38:45 UTC) #9
pals
Submitted a issue in cm https://github.com/marijnh/CodeMirror/issues/2810.
6 years, 3 months ago (2014-09-18 11:51:53 UTC) #10
vsevik
lgtm
6 years, 3 months ago (2014-09-18 22:09:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575783002/20001
6 years, 3 months ago (2014-09-18 22:10:54 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 23:44:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182285

Powered by Google App Engine
This is Rietveld 408576698