Issue 575743006: Fixing sdk gyp_vars mishandled in buildbot script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 575743006: Fixing sdk gyp_vars mishandled in buildbot script. (Closed)

Created:
6 years, 3 months ago by bradn

Modified:
6 years, 3 months ago

Reviewers:
binji, Sam Clegg

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixing sdk gyp_vars mishandled in buildbot script. The SDK has a dependency on an inner interface on the nacl side. We use a fake to share code. Updating the fake to actually provide what the nacl side expects. BUG=None TEST=trybots R=sbc@chromium.org,binji@chromium.org Committed: https://crrev.com/68b33a1f165878f3ef383f5a9b66e233cc6fb137 Cr-Commit-Position: refs/heads/master@{#295148}