Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 575743002: ASSERTION FAILED: child->isTableCell() (Closed)

Created:
6 years, 3 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, aboxhall
CC:
blink-reviews, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ASSERTION FAILED: child->isTableCell() This ASSERTION Fails when the child is not a table cell. Consider the scenario when there is a spelling mistake in defining the role for a gridcell inside a grid. Ex: <div role="grid"> <div role="row"> <span role="columnheader">Word</span> </div> <div role="row"> <span rolw="gridcell">ABCD</span> </div> </div> Also, this ASSERTION is not required because in the next line 'if' check has been made to check whether child is tablecell or not. BUG=412735 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/accessibility/AXTable.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
shreeramk
Please review. Thanks!
6 years, 3 months ago (2014-09-16 10:36:49 UTC) #2
dmazzoni
lgtm Sorry, this one slipped through my radar. Looks fine, thanks.
6 years, 2 months ago (2014-10-21 18:43:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575743002/1
6 years, 2 months ago (2014-10-21 18:44:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/61038)
6 years, 2 months ago (2014-10-21 19:34:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575743002/1
6 years, 2 months ago (2014-10-21 19:42:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/61038)
6 years, 2 months ago (2014-10-21 19:45:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575743002/1
6 years, 2 months ago (2014-10-22 01:56:04 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 03:47:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184139

Powered by Google App Engine
This is Rietveld 408576698