Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 575723002: Delete dead error reporting code from the Safe Browsing interstitial (Closed)

Created:
6 years, 3 months ago by felt
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer, mattm
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Delete dead error reporting code from the Safe Browsing interstitial The phishing warning no longer supports error reporting. This CL deletes the dead code associated with the error reports. BUG= R=mattm@chromium.org Committed: https://crrev.com/a45fa2145d7c9740a4dd06bb8592310d538c866e Cr-Commit-Position: refs/heads/master@{#295065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M chrome/browser/resources/security_warnings/safe_browsing.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 3 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
felt
PTAL. Tiny CL: bauerb@: chrome/browser/resources/security_warnings/safe_browsing.js mattm@: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
6 years, 3 months ago (2014-09-16 04:26:49 UTC) #2
mattm
lgtm
6 years, 3 months ago (2014-09-16 07:22:27 UTC) #3
Bernhard Bauer
LGTM!
6 years, 3 months ago (2014-09-16 07:54:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575723002/1
6 years, 3 months ago (2014-09-16 14:27:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as b1b83494266ac043564124bd4b412540f0985536
6 years, 3 months ago (2014-09-16 14:57:04 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 15:01:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a45fa2145d7c9740a4dd06bb8592310d538c866e
Cr-Commit-Position: refs/heads/master@{#295065}

Powered by Google App Engine
This is Rietveld 408576698