Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 575693002: remove unneeded reference to SkBitmapDevice.h (Closed)

Created:
6 years, 3 months ago by reed2
Modified:
6 years, 3 months ago
Reviewers:
danakj, f(malita), jbauman, reed1
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam, piman+watch_chromium.org, danakj, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove unneeded reference to SkBitmapDevice.h Try failures are unrelated to this CL. NOTRY=True Committed: https://crrev.com/bd2c1d52ae8cd000a3cdad2e32b37e8dfdf2607d Cr-Commit-Position: refs/heads/master@{#295792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M cc/output/renderer_pixeltest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/compositor_software_output_device.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 25 (11 generated)
reed1
6 years, 3 months ago (2014-09-19 14:45:47 UTC) #2
tfarina
CC: danakj regards,
6 years, 3 months ago (2014-09-19 14:54:58 UTC) #4
danakj
LGTM
6 years, 3 months ago (2014-09-19 16:34:52 UTC) #6
danakj
+jbauman for content/
6 years, 3 months ago (2014-09-19 16:35:23 UTC) #8
jbauman
lgtm
6 years, 3 months ago (2014-09-19 19:40:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575693002/1
6 years, 3 months ago (2014-09-19 20:26:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575693002/1
6 years, 3 months ago (2014-09-19 20:26:12 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/11432)
6 years, 3 months ago (2014-09-19 20:53:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575693002/1
6 years, 3 months ago (2014-09-19 21:23:23 UTC) #16
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-19 21:24:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575693002/1
6 years, 3 months ago (2014-09-19 22:12:28 UTC) #21
commit-bot: I haz the power
Failed to apply the patch.
6 years, 3 months ago (2014-09-19 22:19:01 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1) as 45d4e51fa232d65c977d182e28219556d44f6624
6 years, 3 months ago (2014-09-19 22:19:21 UTC) #24
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 22:19:51 UTC) #25
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bd2c1d52ae8cd000a3cdad2e32b37e8dfdf2607d
Cr-Commit-Position: refs/heads/master@{#295792}

Powered by Google App Engine
This is Rietveld 408576698