Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 575653002: Revert of ash: Add checks for supervised users. (Closed)

Created:
6 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, sadrul, oshima+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of ash: Add checks for supervised users. (patchset #5 id:80001 of https://codereview.chromium.org/561713002/) Reason for revert: This is breaking NotificationApiTest.TestUserGesture, which assumes it starts with an empty notification list. Somehow this is causing the browser test to be in a state where there is already a notification in the list regarding a supervised user. Original issue's description: > ash: Add checks for supervised users. > > Propagate the user's supervised state to the ash system > so that it becomes available for views > > https://chromereviews.googleplex.com/79527013/ > > BUG=394417 > > Committed: https://crrev.com/8616ac4cf7bd77f53dc001eb9d8d61c6c975eaaa > Cr-Commit-Position: refs/heads/master@{#294821} TBR=antrim@chromium.org,derat@chromium.org,jennyz@chromium.org,bauerb@chromium.org,treib@chromium.org,merkulova@chromium.org NOTREECHECKS=true NOTRY=true BUG=394417 Committed: https://crrev.com/0b527c1ef9f0794742e8ea004fbaf7ecea2f4cef Cr-Commit-Position: refs/heads/master@{#294934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -90 lines) Patch
M ash/shelf/shelf_widget.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.h View 2 chunks +1 line, -4 lines 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M ash/system/tray/default_system_tray_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/tray/default_system_tray_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/system/tray/system_tray_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/system/user/tray_user.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ash/system/user/user_card_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/test/test_system_tray_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/test_system_tray_delegate.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_linux.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/user_manager/user.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/user_manager/user.cc View 4 chunks +2 lines, -24 lines 0 comments Download
M components/user_manager/user_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/user_manager/user_manager_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/user_manager/user_manager_base.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of ash: Add checks for supervised users.
6 years, 3 months ago (2014-09-15 23:16:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575653002/1
6 years, 3 months ago (2014-09-15 23:32:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8390cdb22fac07ab292d78e42f2b248672b5b1e1
6 years, 3 months ago (2014-09-16 00:00:33 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 00:04:37 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b527c1ef9f0794742e8ea004fbaf7ecea2f4cef
Cr-Commit-Position: refs/heads/master@{#294934}

Powered by Google App Engine
This is Rietveld 408576698