fix sandbox memory leak

fix sandbox memory leak

The memory allocated by AllocAndCopyName was not being freed
if the in-process policy engine did not allow the request to
query the broker.

This was nicely reported by typo.pl@gmail.com

TEST=see bug
BUG=414039
Committed: https://crrev.com/6f396e2512fb2efb968962aec3371b300cdfad2c
Cr-Commit-Position: refs/heads/master@{#295220}

[cpu_(ooo_6.6-7.5), 2014-09-16 23:45:14]

cpu@chromium.org changed reviewers:
+ wfh@chromium.org

[cpu_(ooo_6.6-7.5), 2014-09-16 23:45:31]

there ya go whf.

[Will Harris, 2014-09-16 23:52:30]

On 2014/09/16 23:45:31, cpu wrote:
> there ya go whf.

LGTM, cup.

[cpu_(ooo_6.6-7.5), 2014-09-17 01:52:48]

The CQ bit was checked by cpu@chromium.org

[commit-bot: I haz the power, 2014-09-17 01:53:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/575623004/1

[commit-bot: I haz the power, 2014-09-17 03:24:46]

Committed patchset #1 (id:1) as d39260821dd39ac9077f5af2eba8fb32dd248122

[commit-bot: I haz the power, 2014-09-17 03:25:29]

Patchset 1 (id:??) landed as
https://crrev.com/6f396e2512fb2efb968962aec3371b300cdfad2c
Cr-Commit-Position: refs/heads/master@{#295220}

[Yun, 2014-12-15 03:08:37]

yunli.sharing@gmail.com changed reviewers:
+ yunli.sharing@gmail.com

[Yun, 2014-12-15 03:08:37]

https://codereview.chromium.org/575623004/diff/1/sandbox/win/src/filesystem_i...
File sandbox/win/src/filesystem_interception.cc (right):

https://codereview.chromium.org/575623004/diff/1/sandbox/win/src/filesystem_i...
sandbox/win/src/filesystem_interception.cc:76: return answer.nt_status;
Cannot return. It could cause memeory leak as well.

https://codereview.chromium.org/575623004/diff/1/sandbox/win/src/filesystem_i...
sandbox/win/src/filesystem_interception.cc:144: return answer.nt_status;
Cannot return. It could cause memory leak as well. We can save the return value
to the variable of status and do a break. Please check all other functions below
to make sure following the same handling way.

https://codereview.chromium.org/575623004/diff/1/sandbox/win/src/filesystem_i...
sandbox/win/src/filesystem_interception.cc:206: operator delete(name, NT_ALLOC);
Remove it.

https://codereview.chromium.org/575623004/diff/1/sandbox/win/src/filesystem_i...
sandbox/win/src/filesystem_interception.cc:211: return answer.nt_status;
Change it as:
       status = answer.nt_status;

https://codereview.chromium.org/575623004/diff/1/sandbox/win/src/filesystem_i...
sandbox/win/src/filesystem_interception.cc:267: operator delete(name, NT_ALLOC);
Remove it.

https://codereview.chromium.org/575623004/diff/1/sandbox/win/src/filesystem_i...
sandbox/win/src/filesystem_interception.cc:272: return answer.nt_status;
Change it as:
       status = answer.nt_status;

[Will Harris, 2014-12-16 02:11:08]

I can push a CL to fix these.  Unless Yun, you want to create one?