Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4984)

Unified Diff: chrome/common/extensions/docs/server2/data_source.py

Issue 575613003: Docserver: Gitiles auth and cron refactoring. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/data_source.py
diff --git a/chrome/common/extensions/docs/server2/data_source.py b/chrome/common/extensions/docs/server2/data_source.py
index c31cd4887662c36b684e65f0b86cb5c0412ddeaf..ba0dfb48a290ff3fefb0a410e6e5edb2ac052265 100644
--- a/chrome/common/extensions/docs/server2/data_source.py
+++ b/chrome/common/extensions/docs/server2/data_source.py
@@ -7,10 +7,10 @@ class DataSource(object):
'''
Defines an abstraction for all DataSources.
- DataSources must have two public methods, get and Cron. A DataSource is
+ DataSources must have two public methods, get and Refresh. A DataSource is
initialized with a ServerInstance and a Request (defined in servlet.py).
Anything in the ServerInstance can be used by the DataSource. Request is None
- when DataSources are created for Cron.
+ when DataSources are created for Refresh.
DataSources are used to provide templates with access to data. DataSources may
not access other DataSources and any logic or data that is useful to other
@@ -19,10 +19,17 @@ class DataSource(object):
def __init__(self, server_instance, request):
pass
- def Cron(self):
- '''Must cache all files needed by |get| to persist them. Called on a live
- file system and can access files not in cache. |request| will be None.
+ def GetRefreshPaths(self):
+ '''Returns a list of paths to query
+ (relative to _refresh/<data_source_name>/) with the task queue in order
+ to refresh this DataSource's data set. Any paths listed here will be
+ routed to the DataSource Refresh method in a taskqueue task request.
'''
+ return ['']
+
+ def Refresh(self, path=None):
+ '''Handles _refresh requests to this DataSource. Should return a Future
+ indicating the success or failure of the refresh.'''
raise NotImplementedError(self.__class__)
def get(self, key):
« no previous file with comments | « chrome/common/extensions/docs/server2/custom_logger.py ('k') | chrome/common/extensions/docs/server2/data_source_registry.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698