chrome/common/extensions/docs/server2/instance_servlet.py - Issue 575613003: Docserver: Gitiles auth and cron refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/instance_servlet.py

Issue 575613003: Docserver: Gitiles auth and cron refactoring. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/docs/server2/instance_servlet.py

diff --git a/chrome/common/extensions/docs/server2/instance_servlet.py b/chrome/common/extensions/docs/server2/instance_servlet.py

index a23bb435ec8cf2248fa2f317cf3ae7fd0329aba3..8479d7fd73f94f0c878fe471067216e468c41403 100644

--- a/chrome/common/extensions/docs/server2/instance_servlet.py

+++ b/chrome/common/extensions/docs/server2/instance_servlet.py

@@ -19,8 +19,8 @@ class InstanceServletRenderServletDelegate(RenderServlet.Delegate):

which is as far as instances look. To enable this, crons can pass a custom

(presumably online) ServerInstance into Get().

- Why? SVN is slow and a bit flaky. Cronjobs failing is annoying but temporary.

- Instances failing affects users, and is really bad.

+ Why? SVN is slow and a bit flaky. Refresh jobs failing is annoying but

ahernandez 2014/09/15 23:58:02 Could you please changes instances of SVN to Gitil

Ken Rockot(use gerrit already) 2014/09/16 00:24:31 Done.

+ temporary. Instances failing affects users, and is really bad.

Anyway - to enforce this, we actually don't give instances access to SVN. If

anything is missing from datastore, it'll be a 404. If the cronjobs don't