Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 575613003: Docserver: Gitiles auth and cron refactoring. (Closed)

Created:
6 years, 3 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 3 months ago
Reviewers:
ahernandez
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Docserver: Gitiles auth and cron refactoring. Pardon the dust. This is a large, huge, massive CL. This puts gitiles in a mostly working state with auth. A hard requirement for this is to make the periodic content update process work, and because gitiles is so drastically slow compared to SVN, this meant breaking up the Cron tasks into many small subtasks. More work to follow, but this should allow us to get a live server up and running ASAP. BUG=404239 NOTRY=True TBR=ahernandez.miralles@gmail.com Committed: https://crrev.com/deaf2f7e812fd2bb8e0387491d0d080d1e1fe61e Cr-Commit-Position: refs/heads/master@{#295079}

Patch Set 1 #

Total comments: 8

Patch Set 2 : cleanup #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+597 lines, -296 lines) Patch
M chrome/common/extensions/docs/server2/api_data_source.py View 2 chunks +14 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_list_data_source.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/api_models.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/app.yaml View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/app_engine_handler.py View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/appengine_url_fetcher.py View 3 chunks +20 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/appengine_wrappers.py View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/caching_file_system.py View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/content_provider.py View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/content_provider_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/content_providers.py View 1 2 chunks +15 lines, -10 lines 0 comments Download
M chrome/common/extensions/docs/server2/cron.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/cron_servlet.py View 3 chunks +48 lines, -154 lines 0 comments Download
A chrome/common/extensions/docs/server2/custom_logger.py View 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/data_source.py View 2 chunks +12 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/server2/data_source_registry.py View 1 chunk +13 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/fake_fetchers.py View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/file_system.py View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/gitiles_file_system.py View 1 9 chunks +32 lines, -32 lines 0 comments Download
M chrome/common/extensions/docs/server2/handler.py View 3 chunks +26 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/instance_servlet.py View 1 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/common/extensions/docs/server2/jsc_view.py View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/manifest_data_source.py View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/owners_data_source.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/patch_servlet.py View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/path_canonicalizer.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/permissions_data_source.py View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/platform_bundle.py View 1 chunk +5 lines, -3 lines 0 comments Download
A chrome/common/extensions/docs/server2/queue.yaml View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/redirector.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/redirector_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/common/extensions/docs/server2/refresh_servlet.py View 1 chunk +143 lines, -0 lines 0 comments Download
A chrome/common/extensions/docs/server2/render_refresher.py View 1 chunk +101 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/server2/samples_data_source.py View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/samples_model.py View 1 chunk +11 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/servlet.py View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/sidenav_data_source.py View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/sidenav_data_source_test.py View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/docs/server2/strings_data_source.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/template_data_source.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/url_constants.py View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/server2/whats_new_data_source.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/templates/json/content_providers.json View 2 chunks +2 lines, -10 lines 0 comments Download
A + chrome/common/extensions/docs/templates/private/intro_tables/master_message.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/common/extensions/docs/templates/private/intro_tables/trunk_message.html View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Ken Rockot(use gerrit already)
Here's my patch. Mostly just looking for a rubber stamp rather than a thorough review, ...
6 years, 3 months ago (2014-09-15 22:13:02 UTC) #1
ahernandez
Awesome patch! I've been excited to see these changes. Here's a rubbery lgtm, with a ...
6 years, 3 months ago (2014-09-15 23:58:03 UTC) #2
Ken Rockot(use gerrit already)
Thanks! https://codereview.chromium.org/575613003/diff/1/chrome/common/extensions/docs/server2/appengine_wrappers.py File chrome/common/extensions/docs/server2/appengine_wrappers.py (right): https://codereview.chromium.org/575613003/diff/1/chrome/common/extensions/docs/server2/appengine_wrappers.py#newcode22 chrome/common/extensions/docs/server2/appengine_wrappers.py:22: import google.appengine.ext.blobstore as blobstore On 2014/09/15 23:58:02, ahernandez ...
6 years, 3 months ago (2014-09-16 00:24:31 UTC) #3
ahernandez
https://codereview.chromium.org/575613003/diff/1/chrome/common/extensions/docs/server2/appengine_wrappers.py File chrome/common/extensions/docs/server2/appengine_wrappers.py (right): https://codereview.chromium.org/575613003/diff/1/chrome/common/extensions/docs/server2/appengine_wrappers.py#newcode22 chrome/common/extensions/docs/server2/appengine_wrappers.py:22: import google.appengine.ext.blobstore as blobstore On 2014/09/16 00:24:31, Ken Rockot ...
6 years, 3 months ago (2014-09-16 00:28:54 UTC) #4
Ken Rockot(use gerrit already)
https://codereview.chromium.org/575613003/diff/1/chrome/common/extensions/docs/server2/appengine_wrappers.py File chrome/common/extensions/docs/server2/appengine_wrappers.py (right): https://codereview.chromium.org/575613003/diff/1/chrome/common/extensions/docs/server2/appengine_wrappers.py#newcode22 chrome/common/extensions/docs/server2/appengine_wrappers.py:22: import google.appengine.ext.blobstore as blobstore On 2014/09/16 00:28:53, ahernandez wrote: ...
6 years, 3 months ago (2014-09-16 00:31:20 UTC) #5
Ken Rockot(use gerrit already)
Gonna commit this. I've done enough testing that I'm confident in its contents. If only ...
6 years, 3 months ago (2014-09-16 16:25:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575613003/40001
6 years, 3 months ago (2014-09-16 16:26:43 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 56073c8bc8440374191afb7837a8ceee833cae99
6 years, 3 months ago (2014-09-16 16:29:32 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 16:30:55 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/deaf2f7e812fd2bb8e0387491d0d080d1e1fe61e
Cr-Commit-Position: refs/heads/master@{#295079}

Powered by Google App Engine
This is Rietveld 408576698