Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 575603002: Added Total wakeups count (Closed)

Created:
6 years, 3 months ago by sullivan
Modified:
6 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, dtu, jeremy, qyearsley
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added Total wakeups count BUG= Committed: https://crrev.com/e1d2b1789a39ad9552f676a69441492852a131ab Cr-Commit-Position: refs/heads/master@{#294947}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/perf/metrics/power.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sullivan
6 years, 3 months ago (2014-09-15 21:18:28 UTC) #2
tonyg
lgtm
6 years, 3 months ago (2014-09-15 22:00:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575603002/1
6 years, 3 months ago (2014-09-15 22:04:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as bdf6acb2b491f1cee81070d9d6e57e7fa8f9a133
6 years, 3 months ago (2014-09-16 00:47:30 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e1d2b1789a39ad9552f676a69441492852a131ab Cr-Commit-Position: refs/heads/master@{#294947}
6 years, 3 months ago (2014-09-16 00:49:55 UTC) #7
tonyg
Thanks! Just a reminder to update the alerting. On Mon, Sep 15, 2014 at 5:49 ...
6 years, 3 months ago (2014-09-16 00:54:11 UTC) #8
sullivan
6 years, 3 months ago (2014-09-16 13:55:15 UTC) #9
Message was sent while issue was closed.
+qyearsley, FYI

I switched the monitoring from:
ChromiumPerf/*/tab_switching.*/idle_wakeups_*

to the new:
ChromiumPerf/*/tab_switching.*/idle_wakeups_total

Nice improvement on the partial name matching, btw.

Powered by Google App Engine
This is Rietveld 408576698