Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: net/quic/quic_session_test.cc

Issue 575593002: Fix QUIC crash on ConnectionClose, protected behind renamed flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_LOG_DFATAL_75537267
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/quic/quic_flags.cc ('K') | « net/quic/quic_session.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session_test.cc
diff --git a/net/quic/quic_session_test.cc b/net/quic/quic_session_test.cc
index a29192eba86b566d399a539bf81aefe12c67662f..3806528a56f2030f493a3dd3efa55485970f9ed7 100644
--- a/net/quic/quic_session_test.cc
+++ b/net/quic/quic_session_test.cc
@@ -934,7 +934,7 @@ TEST_P(QuicSessionTest, TooManyUnfinishedStreamsCauseConnectionClose) {
}
// If a buggy/malicious peer creates too many streams that are not ended with
// a FIN or RST then we send a connection close.
- ValueRestore<bool> old_flag(&FLAGS_close_quic_connection_unfinished_streams,
+ ValueRestore<bool> old_flag(&FLAGS_close_quic_connection_unfinished_streams_2,
true);
EXPECT_CALL(*connection_,
@@ -955,6 +955,10 @@ TEST_P(QuicSessionTest, TooManyUnfinishedStreamsCauseConnectionClose) {
EXPECT_EQ(1u, session_.GetNumOpenStreams());
session_.CloseStream(i);
}
+
+ // Called after any new data is received by the session, and triggers the call
+ // to close the connection.
+ session_.PostProcessAfterData();
}
} // namespace
« net/quic/quic_flags.cc ('K') | « net/quic/quic_session.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698