Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: net/quic/quic_flags.cc

Issue 575593002: Fix QUIC crash on ConnectionClose, protected behind renamed flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_LOG_DFATAL_75537267
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_flags.h ('k') | net/quic/quic_session.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_flags.h" 5 #include "net/quic/quic_flags.h"
6 6
7 // TODO(rtenneti): Remove this. 7 // TODO(rtenneti): Remove this.
8 // Do not flip this flag until the flakiness of the 8 // Do not flip this flag until the flakiness of the
9 // net/tools/quic/end_to_end_test is fixed. 9 // net/tools/quic/end_to_end_test is fixed.
10 // If true, then QUIC connections will track the retransmission history of a 10 // If true, then QUIC connections will track the retransmission history of a
(...skipping 12 matching lines...) Expand all
23 23
24 // If true, QUIC crypto reject message will include the reasons for rejection. 24 // If true, QUIC crypto reject message will include the reasons for rejection.
25 bool FLAGS_send_quic_crypto_reject_reason = false; 25 bool FLAGS_send_quic_crypto_reject_reason = false;
26 26
27 // If true, QUIC connections will support FEC protection of data while sending 27 // If true, QUIC connections will support FEC protection of data while sending
28 // packets, to reduce latency of data delivery to the application. The client 28 // packets, to reduce latency of data delivery to the application. The client
29 // must also request FEC protection for the server to use FEC. 29 // must also request FEC protection for the server to use FEC.
30 bool FLAGS_enable_quic_fec = false; 30 bool FLAGS_enable_quic_fec = false;
31 31
32 // If true, a QUIC connection with too many unfinished streams will be closed. 32 // If true, a QUIC connection with too many unfinished streams will be closed.
33 bool FLAGS_close_quic_connection_unfinished_streams = false; 33 bool FLAGS_close_quic_connection_unfinished_streams_2 = false;
ramant (doing other things) 2014/09/15 20:09:26 rch/rjshade: should we enable this flag in chrome?
Ryan Hamilton 2014/09/15 21:45:55 My recommendation would be to let this run server-
ramant (doing other things) 2014/09/15 21:49:15 Cool. thanks
34 34
35 // When true, defaults to BBR congestion control instead of Cubic. 35 // When true, defaults to BBR congestion control instead of Cubic.
36 bool FLAGS_quic_use_bbr_congestion_control = false; 36 bool FLAGS_quic_use_bbr_congestion_control = false;
37 37
38 // If true, only times out QUIC connections when there has been network 38 // If true, only times out QUIC connections when there has been network
39 // activity; packets sent or received. 39 // activity; packets sent or received.
40 bool FLAGS_quic_timeouts_require_activity = false; 40 bool FLAGS_quic_timeouts_require_activity = false;
41 41
42 // If true, the server will accept slightly more streams than the negotiated 42 // If true, the server will accept slightly more streams than the negotiated
43 // limit. 43 // limit.
44 bool FLAGS_quic_allow_more_open_streams = false; 44 bool FLAGS_quic_allow_more_open_streams = false;
OLDNEW
« no previous file with comments | « net/quic/quic_flags.h ('k') | net/quic/quic_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698