Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 575573003: Add a LOG(DFATAL) to a case where packets are acked before being sent. (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Allow_number_of_open_streams_to_grow_75393293
Project:
chromium
Visibility:
Public.

Description

Add a LOG(DFATAL) to a case where packets are acked before being sent. Merge internal change: 75537267 R=rch@chromium.org

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M net/quic/quic_sent_packet_manager.cc View 1 chunk +3 lines, -1 line 3 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 3 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
6 years, 3 months ago (2014-09-15 19:54:52 UTC) #1
ramant (doing other things)
https://codereview.chromium.org/575573003/diff/1/net/quic/quic_sent_packet_manager.cc File net/quic/quic_sent_packet_manager.cc (right): https://codereview.chromium.org/575573003/diff/1/net/quic/quic_sent_packet_manager.cc#newcode725 net/quic/quic_sent_packet_manager.cc:725: LOG(DFATAL) << "Acked packet has zero sent time, largest_observed:" ...
6 years, 3 months ago (2014-09-15 19:56:45 UTC) #3
Ryan Hamilton
lgtm https://codereview.chromium.org/575573003/diff/1/net/quic/quic_sent_packet_manager.cc File net/quic/quic_sent_packet_manager.cc (right): https://codereview.chromium.org/575573003/diff/1/net/quic/quic_sent_packet_manager.cc#newcode725 net/quic/quic_sent_packet_manager.cc:725: LOG(DFATAL) << "Acked packet has zero sent time, ...
6 years, 3 months ago (2014-09-15 21:44:54 UTC) #4
ramant (doing other things)
On 2014/09/15 21:44:54, Ryan Hamilton wrote: > lgtm > > https://codereview.chromium.org/575573003/diff/1/net/quic/quic_sent_packet_manager.cc > File net/quic/quic_sent_packet_manager.cc (right): ...
6 years, 3 months ago (2014-09-15 21:46:43 UTC) #5
ramant (doing other things)
6 years, 3 months ago (2014-09-15 21:47:50 UTC) #6 
https://codereview.chromium.org/575573003/diff/1/net/quic/quic_sent_packet_ma...
File net/quic/quic_sent_packet_manager.cc (right):

https://codereview.chromium.org/575573003/diff/1/net/quic/quic_sent_packet_ma...
net/quic/quic_sent_packet_manager.cc:725: LOG(DFATAL) << "Acked packet has zero
sent time, largest_observed:"
On 2014/09/15 21:44:54, Ryan Hamilton wrote:
> On 2014/09/15 19:56:44, ramant wrote:
> > rch, ian: should we make this DLOG(DFATAL) in chromium? Or this should never
> > happen and we want to crash the browser if it happens.
> 
> I don't have strong feelings about LOG(DFATAL) vs DLOG(DFATAL). LOG(DFATAL) ==
> LOG(ERROR) in non-debug builds so we won't crash in either case.

Sounds great.

Powered by Google App Engine
This is Rietveld 408576698