Source/core/html/HTMLMediaElement.cpp - Issue 575563002: Fix adopting a video element with controls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 575563002: Fix adopting a video element with controls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix philipj@'s comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index a709141682132ddc3829fd251ecc4500baed28bc..b4f6f317e0332e166d021799fe80fb94266a9fe9 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -827,8 +827,8 @@ void HTMLMediaElement::prepareForLoad()

// algorithm, but do it now because we won't start that until after the timer fires and the

// event may have already fired by then.

setShouldDelayLoadEvent(true);

- configureMediaControls();

+ if (hasMediaControls())

+ mediaControls()->reset();

}

void HTMLMediaElement::loadInternal()

« no previous file with comments | « LayoutTests/media/adopt-node-video-controls-crash.html ('k') | no next file » | no next file with comments »