LayoutTests/media/adopt-node-video-controls-crash.html - Issue 575563002: Fix adopting a video element with controls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/adopt-node-video-controls-crash.html

Issue 575563002: Fix adopting a video element with controls (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix TestExpectations and add expected test results Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2	2

3 <html>	3 <html>

4 <head>	4 <head>

5 <script src=media-file.js></script>	5 <script src=media-file.js></script>

6	6

7 <script>	7 <script>

8	8

9 if (window.testRunner) {	9 if (window.testRunner) {

10 testRunner.dumpAsText();	10 testRunner.dumpAsText();

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 function start()	49 function start()

50 {	50 {

51 var video = document.getElementsByTagName('video')[0];	51 var video = document.getElementsByTagName('video')[0];

52 video.addEventListener("loadstart", loadstart);	52 video.addEventListener("loadstart", loadstart);

53 video.src = findMediaFile("video", "content/test");	53 video.src = findMediaFile("video", "content/test");

54 }	54 }

55 </script>	55 </script>

56 </head>	56 </head>

57 <body>	57 <body>

58 <iframe id="iframe" width=340 height=260 ></iframe>	58 <iframe id="iframe" width=340 height=260 ></iframe>

59 <div id=parent><video id=vid></video></div>	59 <div id=parent><video controls id=vid></video></div>
	philipj_slow 2014/09/16 11:59:39 This test is much bigger than it needs to be. Plea This test is much bigger than it needs to be. Please minimize tests to only include the bits needed to reproduce the bu, in this case: <!DOCTYPE html> <title>Insert a video element with controls into another document</title> <script src="../resources/testharness.js"></script> <script src="../resources/testharnessreport.js"></script> <div id="log"></div> <script> test(function() { var video = document.createElement("video"); video.controls = true; video.src = "data:,"; var otherDocument = document.implementation.createHTMLDocument(); otherDocument.body.appendChild(video); }); </script> aberent 2014/09/16 14:45:40 Done. Show quoted text On 2014/09/16 11:59:39, philipj wrote: > This test is much bigger than it needs to be. Please minimize tests to only > include the bits needed to reproduce the bu, in this case: > > <!DOCTYPE html> > <title>Insert a video element with controls into another document</title> > <script src="../resources/testharness.js"></script> > <script src="../resources/testharnessreport.js"></script> > <div id="log"></div> > <script> > test(function() > { > var video = document.createElement("video"); > video.controls = true; > video.src = "data:,"; > > var otherDocument = document.implementation.createHTMLDocument(); > otherDocument.body.appendChild(video); > }); > </script> Done.
60 <p>Tests that we don't crash when moving a video element to a new docume nt.</p>	60 <p>Tests that we don't crash when moving a video element to a new docume nt.</p>

61 <script>start()</script>	61 <script>start()</script>

62 <pre id="console"></pre>	62 <pre id="console"></pre>

63 </body>	63 </body>

64 </html>	64 </html>

65	65

66	66

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/adopt-node-video-controls-crash-expected.txt » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')