Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 575553003: fix battlefield website by disallowing very small coordinates (Closed)

Created:
6 years, 3 months ago by caryclark
Modified:
6 years, 3 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fix battlefield website by disallowing very small coordinates also add and remove comments to document other attempts to fix this that had drawbacks TBR= BUG=414409 Committed: https://skia.googlesource.com/skia/+/65b427cff9cd34a06ff060d65d00cc3615d8fd94

Patch Set 1 #

Patch Set 2 : disallow coincident assert #

Patch Set 3 : add more tests #

Patch Set 4 : add a bunch of tests #

Patch Set 5 : fix asserts in battle tests; 5 of 106 still compute the wrong answer #

Patch Set 6 : mark only the 5 with wrong output as failing #

Patch Set 7 : add more tests #

Patch Set 8 : more tests, more fixes #

Patch Set 9 : fix chrome crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11369 lines, -174 lines) Patch
M gyp/pathops_unittest.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkOpAngle.cpp View 1 2 3 4 4 chunks +13 lines, -9 lines 0 comments Download
M src/pathops/SkOpEdgeBuilder.cpp View 1 2 3 4 5 6 7 8 4 chunks +18 lines, -0 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 2 3 4 5 6 7 8 14 chunks +55 lines, -11 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 5 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
A tests/PathOpsBattles.cpp View 1 2 3 4 5 6 7 8 1 chunk +11183 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PathOpsLineIntersectionTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PathOpsOpLoopThreadedTest.cpp View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 3 4 5 6 7 8 8 chunks +12 lines, -19 lines 0 comments Download
M tools/pathops_sorter.htm View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
M tools/pathops_visualizer.htm View 1 2 3 4 5 6 7 8 2 chunks +65 lines, -133 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
caryclark
6 years, 3 months ago (2014-09-16 18:48:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575553003/160001
6 years, 3 months ago (2014-09-18 17:25:02 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 17:33:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as 65b427cff9cd34a06ff060d65d00cc3615d8fd94

Powered by Google App Engine
This is Rietveld 408576698