Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 575503003: Remove implicit conversions from scoped_refptr to T* in device (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
keybuk
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in device This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Committed: https://crrev.com/0761425c09c0d1f364095aa745f57b59b8843236 Cr-Commit-Position: refs/heads/master@{#294898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M device/bluetooth/bluetooth_chromeos_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M device/bluetooth/bluetooth_socket_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/nfc/nfc_chromeos_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
Some background: Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. ...
6 years, 3 months ago (2014-09-15 20:10:31 UTC) #2
keybuk
lgtm
6 years, 3 months ago (2014-09-15 20:35:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575503003/1
6 years, 3 months ago (2014-09-15 20:39:40 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-09-15 22:03:34 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 22:04:51 UTC) #8
Patchset 1 (id:??) landed as
https://crrev.com/0761425c09c0d1f364095aa745f57b59b8843236
Cr-Commit-Position: refs/heads/master@{#294898}

Powered by Google App Engine
This is Rietveld 408576698