Issue 575473002: Configure d8 & cctest to suppress Windows error dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 575473002: Configure d8 & cctest to suppress Windows error dialogs. (Closed)

Created:
6 years, 3 months ago by sigurds

Modified:
6 years, 3 months ago

Reviewers:
Michael Achenbach, marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	src/d8.cc	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
	M	test/cctest/cctest.cc	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

sigurds

PTAL, here is the cl which tries if it really works: https://codereview.chromium.org/560933004 (atm trybot is ...

6 years, 3 months ago (2014-09-15 14:59:07 UTC) #2

Michael Achenbach

lgtm as it seems to work - please run also the windows trybots on this ...

6 years, 3 months ago (2014-09-15 15:51:47 UTC) #3

sigurds

On 2014/09/15 15:51:47, Michael Achenbach wrote: > lgtm as it seems to work - please ...

6 years, 3 months ago (2014-09-16 08:57:02 UTC) #4

sigurds

6 years, 3 months ago (2014-09-16 08:58:08 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 23962 (presubmit successful).