Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: runtime/vm/flow_graph.cc

Issue 575443002: Refactor generating lazy deoptimization descriptors. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/deferred_objects.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph.cc
===================================================================
--- runtime/vm/flow_graph.cc (revision 40149)
+++ runtime/vm/flow_graph.cc (working copy)
@@ -766,16 +766,6 @@
*env,
num_non_copied_params_,
&parsed_function_);
- // TODO(fschneider): Add predicates CanEagerlyDeoptimize and
- // CanLazilyDeoptimize to instructions to generally deal with instructions
- // that have pushed arguments and input operands.
- // Right now, closure calls are the only instructions that have both. They
- // also don't have an eager deoptimziation point, so the environment attached
- // here is only used for after the call.
- if (instr->IsClosureCall()) {
- deopt_env = deopt_env->DeepCopy(isolate(),
- deopt_env->Length() - instr->InputCount());
- }
instr->SetEnvironment(deopt_env);
for (Environment::DeepIterator it(deopt_env); !it.Done(); it.Advance()) {
Value* use = it.CurrentValue();
« no previous file with comments | « runtime/vm/deferred_objects.cc ('k') | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698