Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 57543004: Don't test kEnableThreadedCompositing in WebGraphicsContext3DCommandBufferImpl (Closed)

Created:
7 years, 1 month ago by piman
Modified:
7 years, 1 month ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Don't test kEnableThreadedCompositing in WebGraphicsContext3DCommandBufferImpl It's a layering violation (and has crazy side effects when instantiating those in the browser). BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233405

Patch Set 1 #

Total comments: 2

Patch Set 2 : name bool, fix android #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M content/browser/aura/gpu_process_transport_factory.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory_android.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 3 chunks +4 lines, -7 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
piman
7 years, 1 month ago (2013-11-04 20:52:52 UTC) #1
jamesr
lgtm. thanks! https://codereview.chromium.org/57543004/diff/1/content/browser/aura/gpu_process_transport_factory.cc File content/browser/aura/gpu_process_transport_factory.cc (right): https://codereview.chromium.org/57543004/diff/1/content/browser/aura/gpu_process_transport_factory.cc#newcode518 content/browser/aura/gpu_process_transport_factory.cc:518: true, could you either give this bool ...
7 years, 1 month ago (2013-11-04 20:54:56 UTC) #2
piman
https://codereview.chromium.org/57543004/diff/1/content/browser/aura/gpu_process_transport_factory.cc File content/browser/aura/gpu_process_transport_factory.cc (right): https://codereview.chromium.org/57543004/diff/1/content/browser/aura/gpu_process_transport_factory.cc#newcode518 content/browser/aura/gpu_process_transport_factory.cc:518: true, On 2013/11/04 20:54:56, jamesr wrote: > could you ...
7 years, 1 month ago (2013-11-04 22:03:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/57543004/90001
7 years, 1 month ago (2013-11-04 22:13:30 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184540
7 years, 1 month ago (2013-11-05 02:35:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/57543004/90001
7 years, 1 month ago (2013-11-05 03:25:15 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-05 04:15:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/57543004/440001
7 years, 1 month ago (2013-11-05 05:13:14 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184897
7 years, 1 month ago (2013-11-05 07:50:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/57543004/440001
7 years, 1 month ago (2013-11-06 00:12:24 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94385
7 years, 1 month ago (2013-11-06 04:44:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/57543004/440001
7 years, 1 month ago (2013-11-06 04:53:52 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94651
7 years, 1 month ago (2013-11-06 09:23:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/57543004/440001
7 years, 1 month ago (2013-11-06 21:13:18 UTC) #14
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 22:45:43 UTC) #15
Message was sent while issue was closed. 
Change committed as 233405

Powered by Google App Engine
This is Rietveld 408576698