Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 575423002: Do not format OpenGLES2 headers in build_gles2_cmd_buffer.py. (Closed)

Created:
6 years, 3 months ago by mazda
Modified:
6 years, 3 months ago
Reviewers:
vmiura, hamaji
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not format OpenGLES2 headers in build_gles2_cmd_buffer.py. ppb_opengles2.h and ppb_opengles2ext_dev.h are no longer generated by build_gles2_cmd_buffer.py, so it is not necessary to format these files. TEST=trybots BUG=411799 Committed: https://crrev.com/88084c5cb0780f4356eb132c1a9751cf875c806f Cr-Commit-Position: refs/heads/master@{#295492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
mazda
PTAL
6 years, 3 months ago (2014-09-18 10:29:00 UTC) #2
hamaji
lgtm
6 years, 3 months ago (2014-09-18 10:32:47 UTC) #3
mazda
vmiura@: Could you do OWNERS review for gpu/command_buffer? Thanks,
6 years, 3 months ago (2014-09-18 10:36:02 UTC) #4
vmiura
lgtm
6 years, 3 months ago (2014-09-18 17:08:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575423002/1
6 years, 3 months ago (2014-09-18 17:25:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as ae5c2dd037897e2bf606b12ca035f8ab7990b4b6
6 years, 3 months ago (2014-09-18 17:55:14 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 17:55:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88084c5cb0780f4356eb132c1a9751cf875c806f
Cr-Commit-Position: refs/heads/master@{#295492}

Powered by Google App Engine
This is Rietveld 408576698