Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 575383002: Make it clear that WeakPtrFactory is the last data member (Closed)

Created:
6 years, 3 months ago by anujsharma
Modified:
6 years, 3 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make it clear that WeakPtrFactory is the last data member Move declaration of AttachmentServiceProxyForTest's destructor to make it clear the WeakPtrFactory is the last data member. BUG=303818 Committed: https://crrev.com/ed1230ad1dc862fd9d5c2bbba01ca88e2563faca Cr-Commit-Position: refs/heads/master@{#295652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sync/internal_api/public/attachments/attachment_service_proxy_for_test.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
6 years, 3 months ago (2014-09-18 08:07:43 UTC) #2
maniscalco
On 2014/09/18 08:07:43, anujsharma wrote: > PTAL LGTM. Thanks for doing this. BTW, I updated ...
6 years, 3 months ago (2014-09-18 16:52:01 UTC) #3
anujsharma
On 2014/09/18 16:52:01, maniscalco wrote: > On 2014/09/18 08:07:43, anujsharma wrote: > > PTAL > ...
6 years, 3 months ago (2014-09-19 02:38:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575383002/1
6 years, 3 months ago (2014-09-19 02:39:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9a420da4c093287733b0d0f1a4a796b06dc9ff27
6 years, 3 months ago (2014-09-19 03:35:34 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 03:36:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed1230ad1dc862fd9d5c2bbba01ca88e2563faca
Cr-Commit-Position: refs/heads/master@{#295652}

Powered by Google App Engine
This is Rietveld 408576698