Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 575353002: Don't squash into RenderPart subclasses. Don't squash into video elements. (Closed)

Created:
6 years, 3 months ago by chrishtr
Modified:
6 years, 3 months ago
Reviewers:
Ian Vollick
CC:
abarth-chromium, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Don't squash into RenderPart subclasses. Don't squash into video elements. BUG=409885 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182342

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -218 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A + LayoutTests/compositing/squashing/dont-squash-into-iframes.html View 1 chunk +3 lines, -4 lines 0 comments Download
A + LayoutTests/compositing/squashing/dont-squash-into-iframes-expected.txt View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + LayoutTests/compositing/squashing/dont-squash-into-videos.html View 1 chunk +3 lines, -4 lines 0 comments Download
A + LayoutTests/compositing/squashing/dont-squash-into-videos-expected.txt View 1 chunk +11 lines, -11 lines 0 comments Download
M LayoutTests/fast/repaint/video-unmute-repaint-expected.txt View 1 1 chunk +7 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/compositing/video/video-poster-expected.txt View 1 1 chunk +7 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/compositing/iframes/become-overlapped-iframe-expected.txt View 1 1 chunk +23 lines, -26 lines 0 comments Download
M LayoutTests/platform/win/compositing/iframes/connect-compositing-iframe-expected.txt View 1 1 chunk +23 lines, -26 lines 0 comments Download
M LayoutTests/platform/win/compositing/iframes/connect-compositing-iframe2-expected.txt View 1 1 chunk +23 lines, -26 lines 0 comments Download
M LayoutTests/platform/win/compositing/iframes/enter-compositing-iframe-expected.txt View 1 1 chunk +23 lines, -26 lines 0 comments Download
M LayoutTests/platform/win/compositing/iframes/iframe-resize-expected.txt View 1 1 chunk +23 lines, -26 lines 0 comments Download
M LayoutTests/platform/win/compositing/iframes/iframe-size-from-zero-expected.txt View 1 1 chunk +23 lines, -26 lines 0 comments Download
M LayoutTests/platform/win/compositing/iframes/overlapped-iframe-expected.txt View 1 1 chunk +23 lines, -26 lines 0 comments Download
M LayoutTests/platform/win/media/video-paint-invalidation-expected.txt View 1 1 chunk +7 lines, -2 lines 0 comments Download
M Source/core/rendering/compositing/CompositingLayerAssigner.cpp View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
chrishtr
6 years, 3 months ago (2014-09-18 04:45:39 UTC) #2
Ian Vollick
On 2014/09/18 04:45:39, chrishtr wrote: Totally reasonable. lgtm.
6 years, 3 months ago (2014-09-18 18:09:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575353002/1
6 years, 3 months ago (2014-09-18 19:56:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/25487)
6 years, 3 months ago (2014-09-18 20:58:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575353002/20001
6 years, 3 months ago (2014-09-18 21:23:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/27767)
6 years, 3 months ago (2014-09-18 23:08:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/575353002/40001
6 years, 3 months ago (2014-09-19 16:47:07 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 16:53:09 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 182342

Powered by Google App Engine
This is Rietveld 408576698