Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 575343002: [Clean-up] Remove unnecessary default: NOTREACHED() case. (Closed)

Created:
6 years, 3 months ago by Ilya Sherman
Modified:
6 years, 2 months ago
Reviewers:
keybuk, rpaquay
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Clean-up] Remove unnecessary default: NOTREACHED() case. The (clang) compiler is smart enough to catch this error at compile-time, which is better than waiting until runtime. BUG=none TEST=none R=keybuk@chromium.org Committed: https://crrev.com/267aeeb8d85c8503a7fd12bd14654b8ea78d3974 Cr-Commit-Position: refs/heads/master@{#297060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M extensions/browser/api/bluetooth_socket/bluetooth_api_socket.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ilya Sherman
6 years, 3 months ago (2014-09-18 04:33:26 UTC) #1
Ilya Sherman
+Renaud
6 years, 2 months ago (2014-09-26 04:02:42 UTC) #3
rpaquay
lgtm
6 years, 2 months ago (2014-09-26 21:27:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575343002/1
6 years, 2 months ago (2014-09-26 21:34:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 33f06076e138bc910a010914c44be0ced5e7e3f9
6 years, 2 months ago (2014-09-26 22:40:12 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 22:41:11 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/267aeeb8d85c8503a7fd12bd14654b8ea78d3974
Cr-Commit-Position: refs/heads/master@{#297060}

Powered by Google App Engine
This is Rietveld 408576698