ui/webui/resources/js/event_tracker.js - Issue 575333002: Compile print_preview, part 2: reduce down to 260 errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/event_tracker.js

Issue 575333002: Compile print_preview, part 2: reduce down to 260 errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@I_print_preview

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/event_tracker.js

diff --git a/ui/webui/resources/js/event_tracker.js b/ui/webui/resources/js/event_tracker.js

index d28c5b7ff55130fb542616680ec41a5370762557..ca958ffa6a8e80460a2bee5393e4126196496638 100644

--- a/ui/webui/resources/js/event_tracker.js

+++ b/ui/webui/resources/js/event_tracker.js

@@ -40,7 +40,7 @@ function EventTracker() {

EventTracker.prototype = {

/**

* Add an event listener - replacement for Node.addEventListener.

- * @param {!Node} node The DOM node to add a listener to.

+ * @param {!EventTarget} node The DOM node to add a listener to.

Dan Beam 2014/09/23 00:46:34 shouldn't we rename to target everywhere?

Vitaly Pavlenko 2014/09/23 01:05:17 Done inside this function. Or you mean everywhere

* @param {string} eventType The type of event to subscribe to.

* @param {EventListener|Function} listener The listener to add.

* @param {boolean=} opt_capture Whether to invoke during the capture phase.

« ui/webui/resources/js/cr/event_target.js ('K') | « ui/webui/resources/js/cr/event_target.js ('k') | no next file » | no next file with comments »