Compile print_preview, part 2: reduce down to 260 errors

chrome/browser/resources/print_preview/data/destination.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+cr.exportPath('print_preview');
+
+/**
+ * The CDD (Cloud Device Description) describes the capabilities of a print
+ * destination.
+ *
+ * @typedef {{
+ *   version: string,
+ *   printer: {
+ *     vendor_capability: !Array.<{Object}>,
+ *     collate: ({default: (boolean|undefined)}|undefined),
+ *     color: ({
+ *       option: !Array.<{
+ *         type: (string|undefined),
+ *         vendor_id: (string|undefined),
+ *         custom_display_name: (string|undefined),
+ *         is_default: (boolean|undefined)
+ *       }>
+ *     }|undefined),
+ *     copies: ({default: (number|undefined),
+ *               max: (number|undefined)}|undefined),
+ *     duplex: ({option: !Array.<{type: (string|undefined),
+ *                               is_default: (boolean|undefined)}>}|undefined),
+ *     page_orientation: ({
+ *       option: !Array.<{type: (string|undefined),
+ *                        is_default: (boolean|undefined)}>
+ *     }|undefined)
+ *   }
+ * }}
+ */
+print_preview.Cdd;
+
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Print destination data object that holds data for both local and cloud
    * destinations.
    * @param {string} id ID of the destination.
    * @param {!print_preview.Destination.Type} type Type of the destination.
    * @param {!print_preview.Destination.Origin} origin Origin of the
    *     destination.
@@ skipping 92 matching lines @@
      */
     this.lastAccessTime_ = (opt_params && opt_params.lastAccessTime) ||
                            Date.now();
 
     /**
      * Whether the user has accepted the terms-of-service for the print
      * destination. Only applies to the FedEx Office cloud-based printer.
      * {@code null} if terms-of-service does not apply to the print destination.
      * @private {?boolean}
      */
-    this.isTosAccepted_ = opt_params && opt_params.isTosAccepted;
+    this.isTosAccepted_ = !!(opt_params && opt_params.isTosAccepted);
 
     /**
      * Cloud ID for Privet printers.
      * @private {string}
      */
     this.cloudID_ = (opt_params && opt_params.cloudID) || '';
   };
 
   /**
    * Prefix of the location destination tag.
    * @type {!Array.<string>}
    * @const
    */
   Destination.LOCATION_TAG_PREFIXES = [
     '__cp__location=',
     '__cp__printer-location='
   ];
 
   /**
-   * Enumeration of Google-promoted destination IDs.
-   * @enum {string}
-   */
-  Destination.GooglePromotedId = {
-    DOCS: '__google__docs',
-    FEDEX: '__google__fedex',
-    SAVE_AS_PDF: 'Save as PDF'
-  };
-
-  /**
-   * Enumeration of the types of destinations.
-   * @enum {string}
-   */
-  Destination.Type = {
-    GOOGLE: 'google',
-    LOCAL: 'local',
-    MOBILE: 'mobile'
-  };
-
-  /**
-   * Enumeration of the origin types for cloud destinations.
-   * @enum {string}
-   */
-  Destination.Origin = {
-    LOCAL: 'local',
-    COOKIES: 'cookies',
-    PROFILE: 'profile',
-    DEVICE: 'device',
-    PRIVET: 'privet'
-  };
-
-  /**
-   * Enumeration of the connection statuses of printer destinations.
-   * @enum {string}
-   */
-  Destination.ConnectionStatus = {
-    DORMANT: 'DORMANT',
-    OFFLINE: 'OFFLINE',
-    ONLINE: 'ONLINE',
-    UNKNOWN: 'UNKNOWN',
-    UNREGISTERED: 'UNREGISTERED'
-  };
-
-  /**
    * Enumeration of relative icon URLs for various types of destinations.
    * @enum {string}
    * @private
    */
   Destination.IconUrl_ = {
     CLOUD: 'images/printer.png',
     CLOUD_SHARED: 'images/printer_shared.png',
     LOCAL: 'images/printer.png',
     MOBILE: 'images/mobile.png',
     MOBILE_SHARED: 'images/mobile_shared.png',
@@ skipping 225 matching lines @@
       return [this.location, this.description];
     },
 
     /**
      * Matches a query against the destination.
      * @param {!RegExp} query Query to match against the destination.
      * @return {boolean} {@code true} if the query matches this destination,
      *     {@code false} otherwise.
      */
     matches: function(query) {
-      return this.displayName_.match(query) ||
+      return !!this.displayName_.match(query) ||
           this.extraPropertiesToMatch.some(function(property) {
             return property.match(query);
           });
     }
   };
 
-  /**
-   * The CDD (Cloud Device Description) describes the capabilities of a print
-   * destination.
-   *
-   * @typedef {{
-   *   version: string,
-   *   printer: {
-   *     vendor_capability: !Array.<{Object}>,
-   *     collate: {default: boolean=}=,
-   *     color: {
-   *       option: !Array.<{
-   *         type: string=,
-   *         vendor_id: string=,
-   *         custom_display_name: string=,
-   *         is_default: boolean=
-   *       }>
-   *     }=,
-   *     copies: {default: number=, max: number=}=,
-   *     duplex: {option: !Array.<{type: string=, is_default: boolean=}>}=,
-   *     page_orientation: {
-   *       option: !Array.<{type: string=, is_default: boolean=}>
-   *     }=
-   *   }
-   * }}
-   */
-  var Cdd = Object;
-
   // Export
   return {
     Destination: Destination,
-    Cdd: Cdd
   };
 });
+
+/**
+ * Enumeration of Google-promoted destination IDs.
+ * @enum {string}
+ */
+print_preview.Destination.GooglePromotedId = {
+  DOCS: '__google__docs',
+  FEDEX: '__google__fedex',
+  SAVE_AS_PDF: 'Save as PDF'
+};
+
+/**
+ * Enumeration of the types of destinations.
+ * @enum {string}
+ */
+print_preview.Destination.Type = {
+  GOOGLE: 'google',
+  GOOGLE_PROMOTED: 'google_promoted',
+  LOCAL: 'local',
+  MOBILE: 'mobile'
+};
+
+/**
+ * Enumeration of the origin types for cloud destinations.
+ * @enum {string}
+ */
+print_preview.Destination.Origin = {
+  LOCAL: 'local',
+  COOKIES: 'cookies',
+  PROFILE: 'profile',
+  DEVICE: 'device',
+  PRIVET: 'privet'
+};
+
+/**
+ * Enumeration of the connection statuses of printer destinations.
+ * @enum {string}
+ */
+print_preview.Destination.ConnectionStatus = {
+  DORMANT: 'DORMANT',
+  OFFLINE: 'OFFLINE',
+  ONLINE: 'ONLINE',
+  UNKNOWN: 'UNKNOWN',
+  UNREGISTERED: 'UNREGISTERED'
+};