Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: remoting/webapp/fullscreen_v1.js

Issue 575303002: Fix bump-scroll on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | remoting/webapp/toolbar.css » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * Full-screen implementation for apps v1, using webkitRequestFullscreen. 7 * Full-screen implementation for apps v1, using webkitRequestFullscreen.
8 */ 8 */
9 9
10 'use strict'; 10 'use strict';
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 }; 72 };
73 73
74 remoting.FullscreenAppsV1.prototype.removeListener = function(callback) { 74 remoting.FullscreenAppsV1.prototype.removeListener = function(callback) {
75 this.eventSource_.removeEventListener(this.kEventName_, callback); 75 this.eventSource_.removeEventListener(this.kEventName_, callback);
76 }; 76 };
77 77
78 /** 78 /**
79 * @private 79 * @private
80 */ 80 */
81 remoting.FullscreenAppsV1.prototype.onFullscreenChanged_ = function() { 81 remoting.FullscreenAppsV1.prototype.onFullscreenChanged_ = function() {
82 this.eventSource_.raiseEvent(this.kEventName_, this.isActive()); 82 // Querying full-screen immediately after the webkitfullscreenchange
83 // event fires sometimes gives the wrong answer on Mac, perhaps due to
84 // the time taken to animate presentation mode. Since I haven't been able
85 // to isolate the exact repro steps, and we're not planning on using this
86 // API for much longer, this hack will suffice for now.
87 window.setTimeout(
88 /** @this {remoting.FullscreenAppsV1} */
89 function() {
90 this.eventSource_.raiseEvent(this.kEventName_, this.isActive());
91 }.bind(this),
92 500);
83 }; 93 };
OLDNEW
« no previous file with comments | « no previous file | remoting/webapp/toolbar.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698