Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 575303002: Fix bump-scroll on Mac. (Closed)

Created:
6 years, 3 months ago by Jamie
Modified:
6 years, 3 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix bump-scroll on Mac. This also fixes a bug in the tool-bar position when the window is scrolled. BUG=411996 Committed: https://crrev.com/458c86efe592bf8eeaa21cd3e9fb9fc211789d3b Cr-Commit-Position: refs/heads/master@{#295526}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M remoting/webapp/fullscreen_v1.js View 1 chunk +11 lines, -1 line 0 comments Download
M remoting/webapp/toolbar.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie
PTAL. Not my finest CL, but it's suitable for merging to M38, and given that ...
6 years, 3 months ago (2014-09-18 01:17:59 UTC) #2
kelvinp
lgtm
6 years, 3 months ago (2014-09-18 18:37:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575303002/20001
6 years, 3 months ago (2014-09-18 18:41:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1e5cec949f1d03df378a63d446a68910caac8417
6 years, 3 months ago (2014-09-18 19:36:48 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 19:37:18 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/458c86efe592bf8eeaa21cd3e9fb9fc211789d3b
Cr-Commit-Position: refs/heads/master@{#295526}

Powered by Google App Engine
This is Rietveld 408576698