|
|
Created:
6 years, 3 months ago by tandrii(chromium) Modified:
6 years, 3 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionAdded allowed_hosts to DEPS.
BUG=371012
Committed: https://crrev.com/74b7e421fe6f670442b53c9726016972fe55b83e
Cr-Commit-Position: refs/heads/master@{#296203}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Added comment for allowed_hosts. #Patch Set 3 : Fixed typo. #Messages
Total messages: 20 (7 generated)
tandrii@chromium.org changed reviewers: + iannucci@chromium.org
tandrii@chromium.org changed reviewers: + iannucci@chromium.org
Follow up of the https://codereview.chromium.org/578423002/ and https://codereview.chromium.org/562953002
Follow up of the https://codereview.chromium.org/578423002/ and https://codereview.chromium.org/562953002
tandrii@chromium.org changed reviewers: + sergiyb@google.com
tandrii@chromium.org changed reviewers: + sergiyb@chromium.org - sergiyb@google.com
https://codereview.chromium.org/575283005/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/575283005/diff/1/DEPS#newcode93 DEPS:93: allowed_hosts = [ Add a comment above this explaining that this restricts the hostnames allowed in this DEPS file. If they want a new host, talk to the chrome infrastructure team.
PTAL https://codereview.chromium.org/575283005/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/575283005/diff/1/DEPS#newcode93 DEPS:93: allowed_hosts = [ On 2014/09/18 21:01:32, iannucci wrote: > Add a comment above this explaining that this restricts the hostnames allowed in > this DEPS file. If they want a new host, talk to the chrome infrastructure team. Done.
l-g-t-m, but since I am not familiar with this script, I'll leave it to iannucci to approve it
lgtm
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575283005/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tandrii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575283005/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 4ac93f68f7a864912316e35b8eb6f0d4a758bbee
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/74b7e421fe6f670442b53c9726016972fe55b83e Cr-Commit-Position: refs/heads/master@{#296203} |