Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 575283005: Added allowed_hosts to DEPS. (Closed)

Created:
6 years, 3 months ago by tandrii(chromium)
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added allowed_hosts to DEPS. BUG=371012 Committed: https://crrev.com/74b7e421fe6f670442b53c9726016972fe55b83e Cr-Commit-Position: refs/heads/master@{#296203}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment for allowed_hosts. #

Patch Set 3 : Fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M DEPS View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
tandrii(chromium)
Follow up of the https://codereview.chromium.org/578423002/ and https://codereview.chromium.org/562953002
6 years, 3 months ago (2014-09-18 19:51:46 UTC) #3
tandrii(chromium)
Follow up of the https://codereview.chromium.org/578423002/ and https://codereview.chromium.org/562953002
6 years, 3 months ago (2014-09-18 19:51:46 UTC) #4
tandrii(chromium)
6 years, 3 months ago (2014-09-18 20:02:25 UTC) #6
tandrii(chromium)
6 years, 3 months ago (2014-09-18 20:05:46 UTC) #8
iannucci
https://codereview.chromium.org/575283005/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/575283005/diff/1/DEPS#newcode93 DEPS:93: allowed_hosts = [ Add a comment above this explaining ...
6 years, 3 months ago (2014-09-18 21:01:33 UTC) #9
tandrii(chromium)
PTAL https://codereview.chromium.org/575283005/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/575283005/diff/1/DEPS#newcode93 DEPS:93: allowed_hosts = [ On 2014/09/18 21:01:32, iannucci wrote: ...
6 years, 3 months ago (2014-09-18 22:07:27 UTC) #10
Sergiy Byelozyorov
l-g-t-m, but since I am not familiar with this script, I'll leave it to iannucci ...
6 years, 3 months ago (2014-09-22 13:34:15 UTC) #11
iannucci
lgtm
6 years, 3 months ago (2014-09-22 17:46:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575283005/40001
6 years, 3 months ago (2014-09-23 12:42:08 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/16486)
6 years, 3 months ago (2014-09-23 12:58:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/575283005/40001
6 years, 3 months ago (2014-09-23 16:44:53 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 4ac93f68f7a864912316e35b8eb6f0d4a758bbee
6 years, 3 months ago (2014-09-23 16:45:43 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 16:46:20 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/74b7e421fe6f670442b53c9726016972fe55b83e
Cr-Commit-Position: refs/heads/master@{#296203}

Powered by Google App Engine
This is Rietveld 408576698