components/pairing/bluetooth_controller_pairing_controller.h - Issue 575273002: Clean up protocol for Bluetooth Pairing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/pairing/bluetooth_controller_pairing_controller.h

Issue 575273002: Clean up protocol for Bluetooth Pairing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review fixes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/pairing/bluetooth_controller_pairing_controller.h

diff --git a/components/pairing/bluetooth_controller_pairing_controller.h b/components/pairing/bluetooth_controller_pairing_controller.h

index 7458154c7136cc4e1b9d2623de395716a0409240..d1846e43d345914f0b634478c6ff4ff80a4ff47a 100644

--- a/components/pairing/bluetooth_controller_pairing_controller.h

+++ b/components/pairing/bluetooth_controller_pairing_controller.h

@@ -38,6 +38,7 @@ class BluetoothControllerPairingController

void Reset();

void DeviceFound(device::BluetoothDevice* device);

void DeviceLost(device::BluetoothDevice* device);

+ void SendBuffer(int size, scoped_refptr<net::IOBuffer> io_buffer);

achuithb 2014/09/18 06:59:17 Is it common to have size before the buffer? I'm f

Zachary Kuznia 2014/09/18 23:48:17 I was following a convention set by another review

void OnSetPowered();

void OnGetAdapter(scoped_refptr<device::BluetoothAdapter> adapter);