Clean up protocol for Bluetooth Pairing.

Clean up protocol for Bluetooth Pairing.

- Add helper buffer for sending IOBuffer
- Add initialization error states.
- Make the device name more human-readable.

BUG=405744, 405774
Committed: https://crrev.com/32ac1c8de6b465d1638085b86008f546fb672a96
Cr-Commit-Position: refs/heads/master@{#295629}

[Zachary Kuznia, 2014-09-18 00:15:35]

zork@chromium.org changed reviewers:
+ dzhioev@chromium.org

[Zachary Kuznia, 2014-09-18 00:15:35]

Please take a look

[dzhioev (left Google), 2014-09-18 04:12:37]

https://codereview.chromium.org/575273002/diff/1/components/pairing/bluetooth...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/575273002/diff/1/components/pairing/bluetooth...
components/pairing/bluetooth_host_pairing_controller.cc:129: 
Does this cycle calculate some hash function?
Can we replace it with "devise_id = base::Hash(adapter_->GetAddress()) &
0xFFFF"?

https://codereview.chromium.org/575273002/diff/1/components/pairing/bluetooth...
components/pairing/bluetooth_host_pairing_controller.cc:130: device_name_ =
base::StringPrintf("%s%04X", kDeviceNamePrefix, device_id);
You should use 'unsigned int' with 'X' flag.

[achuithb, 2014-09-18 06:59:16]

achuith@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2014-09-18 06:59:17]

looks good overall. Pavel can do the final lg2m when he is satisfied.

https://codereview.chromium.org/575273002/diff/20001/components/pairing/bluet...
File components/pairing/bluetooth_controller_pairing_controller.h (right):

https://codereview.chromium.org/575273002/diff/20001/components/pairing/bluet...
components/pairing/bluetooth_controller_pairing_controller.h:41: void
SendBuffer(int size, scoped_refptr<net::IOBuffer> io_buffer);
Is it common to have size before the buffer? I'm familiar with linux send where
it's the opposite:
http://linux.die.net/man/2/send

BluetoothSocket also does it this way:
https://code.google.com/p/chromium/codesearch#chromium/src/device/bluetooth/b...

https://codereview.chromium.org/575273002/diff/20001/components/pairing/bluet...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/575273002/diff/20001/components/pairing/bluet...
components/pairing/bluetooth_host_pairing_controller.cc:122: uint32 device_id =
base::Hash(adapter_->GetAddress()) & 0xFFFF;
A comment would help here. I'm guessing you're masking out everything but the
lowest 2 bytes. 

Also const uint32

[achuithb, 2014-09-18 07:00:29]

Oh - could you also please expand the description to note that you have:

* introduced the helper SendBuffer
* fixed a few places where we need to be in error state.
* anything else.

[Zachary Kuznia, 2014-09-18 08:45:47]

https://codereview.chromium.org/575273002/diff/1/components/pairing/bluetooth...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/575273002/diff/1/components/pairing/bluetooth...
components/pairing/bluetooth_host_pairing_controller.cc:129: 
On 2014/09/18 04:12:37, dzhioev wrote:
> Does this cycle calculate some hash function?
> Can we replace it with "devise_id = base::Hash(adapter_->GetAddress()) &
> 0xFFFF"?

Good call, done and done.

https://codereview.chromium.org/575273002/diff/1/components/pairing/bluetooth...
components/pairing/bluetooth_host_pairing_controller.cc:130: device_name_ =
base::StringPrintf("%s%04X", kDeviceNamePrefix, device_id);
On 2014/09/18 04:12:37, dzhioev wrote:
> You should use 'unsigned int' with 'X' flag.

Done.

[dzhioev (left Google), 2014-09-18 09:07:43]

On 2014/09/18 08:45:47, Zachary Kuznia wrote:
>
https://codereview.chromium.org/575273002/diff/1/components/pairing/bluetooth...
> File components/pairing/bluetooth_host_pairing_controller.cc (right):
> 
>
https://codereview.chromium.org/575273002/diff/1/components/pairing/bluetooth...
> components/pairing/bluetooth_host_pairing_controller.cc:129: 
> On 2014/09/18 04:12:37, dzhioev wrote:
> > Does this cycle calculate some hash function?
> > Can we replace it with "devise_id = base::Hash(adapter_->GetAddress()) &
> > 0xFFFF"?
> 
> Good call, done and done.
> 
>
https://codereview.chromium.org/575273002/diff/1/components/pairing/bluetooth...
> components/pairing/bluetooth_host_pairing_controller.cc:130: device_name_ =
> base::StringPrintf("%s%04X", kDeviceNamePrefix, device_id);
> On 2014/09/18 04:12:37, dzhioev wrote:
> > You should use 'unsigned int' with 'X' flag.
> 
> Done.

LGTM

[Zachary Kuznia, 2014-09-18 23:48:17]

https://codereview.chromium.org/575273002/diff/20001/components/pairing/bluet...
File components/pairing/bluetooth_controller_pairing_controller.h (right):

https://codereview.chromium.org/575273002/diff/20001/components/pairing/bluet...
components/pairing/bluetooth_controller_pairing_controller.h:41: void
SendBuffer(int size, scoped_refptr<net::IOBuffer> io_buffer);
On 2014/09/18 06:59:17, achuithb wrote:
> Is it common to have size before the buffer? I'm familiar with linux send
where
> it's the opposite:
> http://linux.die.net/man/2/send
> 
> BluetoothSocket also does it this way:
>
https://code.google.com/p/chromium/codesearch#chromium/src/device/bluetooth/b...

I was following a convention set by another review.  It seems to have been in
error, though.  Done.

https://codereview.chromium.org/575273002/diff/20001/components/pairing/bluet...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/575273002/diff/20001/components/pairing/bluet...
components/pairing/bluetooth_host_pairing_controller.cc:122: uint32 device_id =
base::Hash(adapter_->GetAddress()) & 0xFFFF;
On 2014/09/18 06:59:17, achuithb wrote:
> A comment would help here. I'm guessing you're masking out everything but the
> lowest 2 bytes. 
> 
> Also const uint32

Done.

[Zachary Kuznia, 2014-09-18 23:48:38]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-09-18 23:51:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/575273002/40001

[commit-bot: I haz the power, 2014-09-19 01:05:04]

Committed patchset #3 (id:40001) as c14af24cc5dc362e3f3f6a9cb53e06fe54d1e2e8

[commit-bot: I haz the power, 2014-09-19 01:06:10]

Patchset 3 (id:??) landed as
https://crrev.com/32ac1c8de6b465d1638085b86008f546fb672a96
Cr-Commit-Position: refs/heads/master@{#295629}